{Packaging} Add missing dependencies for azure-cli-core
#20740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiasli
requested review from
calvinhzy,
evelyn-ys,
jsntcy,
kairu-ms and
zhoxing-ms
as code owners
jiasli
changed the title
msrestazure dependencymsrestazure dependency for azure-cli-core
zhoxing-ms
approved these changes
Dec 15, 2021
evelyn-ys
approved these changes
Dec 16, 2021
calvinhzy
approved these changes
Dec 16, 2021
jiasli
changed the title
msrestazure dependency for azure-cli-coreazure-cli-core
jiasli
changed the title
azure-cli-coreazure-cli-core
jiasli
commented
Feb 7, 2023
| @@ -53,6 +53,8 @@ | |||
| 'knack~=0.9.0', | |||
| 'msal-extensions>=0.3.1,<0.4', | |||
| 'msal>=1.16.0,<2.0.0', | |||
| 'msrestazure~=0.6.4', | |||
| 'packaging>=20.9,<22.0', | |||
There was a problem hiding this comment.
The version bound is copied from #20661. We set the upper bound simply because we don't want unexpected breaking change, which is a value point today.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #20732
msrestazuremsrestazureis indeed needed byazure-cli-coreto authenticate with managed identity:azure-cli/src/azure-cli-core/azure/cli/core/auth/adal_authentication.py
Line 8 in d7e5ede
It works now without declaring
msrestazuredependency becausemsrestazureis installed by Track 1 SDKs.packagingpackagingis needed by extension operations:azure-cli/src/azure-cli-core/azure/cli/core/extension/__init__.py
Line 283 in ed6e829
It works now without declaring
packagingdependency becausepackagingis installed byazure-cli:azure-cli/src/azure-cli/setup.py
Line 144 in d5314ba