{Core} Additional logic to judge whether client is track2
#21353
Conversation
|
Instead of depending on internal files like |
| @@ -634,7 +634,7 @@ def is_track2(client_class): | |||
| """ | |||
| from inspect import getfullargspec as get_arg_spec | |||
| args = get_arg_spec(client_class.__init__).args | |||
| return "credential" in args | |||
| return "credential" in args or hasattr(client_class, "_send_request") | |||
There was a problem hiding this comment.
@msyyc I actually shouldn't have hid the signature yesterday, since that hides the signature for end users. I ended up changing it in the PR before you released yesterday. However this does make sense. For our new DPG generations, we expose send_request as public, so we can maybe add that check as well. But I think I did mess up yesterday by hiding the init signature, so I think it's ok for the CLI code to stay as is
There was a problem hiding this comment.
the PR is discussed about in e-mail: RE: Testing candidates azure-core on CLI testsuite
Description
Current logic of is_track2 is not accurate, especially when the client is patched with hidden signature: Azure/azure-sdk-for-python#23089 (comment).