Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{Packaging} Unify applicationinsights versions and remove wrapt #21557

Merged
merged 2 commits into from
Mar 9, 2022

Conversation

jiasli
Copy link
Member

@jiasli jiasli commented Mar 8, 2022

Description

Address concerns from microsoft/component-detection#74 (comment)

applicationinsights

applicationinsights dependency was introduced by #9785, but it has different versions on different platforms for unknown reason, possible simply due to a mistake:

applicationinsights==0.11.7

applicationinsights==0.11.9

applicationinsights==0.11.9

This PR unifies applicationinsights versions.

wrapt

wrapt is an indirect dependency:

> pipdeptree --reverse --packages wrapt
wrapt==1.13.3
  - astroid==2.8.6 [requires: wrapt>=1.11,<1.14]
    - pylint==2.11.1 [requires: astroid>=2.8.0,<2.9]
      - azdev==0.1.36 [requires: pylint==2.11.1]
  - Deprecated==1.2.13 [requires: wrapt>=1.10,<2]
    - PyGithub==1.55 [requires: deprecated]
      - azure-cli==2.32.0 [requires: PyGithub~=1.38]
  - vcrpy==4.1.1 [requires: wrapt]
    - azure-cli-testsdk==0.3.0 [requires: vcrpy>=1.10.3]
    - azure-devtools==1.2.0 [requires: vcrpy>=1.11.0]

So there is no need to pin its version.

@ghost ghost requested a review from wangzelin007 March 8, 2022 06:33
@jiasli jiasli self-assigned this Mar 8, 2022
@ghost ghost requested review from yonzhan and kairu-ms March 8, 2022 06:33
@ghost ghost added the Auto-Assign Auto assign by bot label Mar 8, 2022
@ghost ghost added this to the Mar 2022 (2022-04-05) milestone Mar 8, 2022
@ghost ghost added the Packaging label Mar 8, 2022
@jiasli jiasli changed the title {Packaging} Unify applicationinsights versions {Packaging} Unify applicationinsights versions and remove wrapt Mar 8, 2022
@yonzhan
Copy link
Collaborator

yonzhan commented Mar 8, 2022

Packaging

@jiasli
Copy link
Member Author

jiasli commented Mar 8, 2022

applicationinsights is used by telemetry

from applicationinsights import TelemetryClient
from applicationinsights.channel import SynchronousSender, SynchronousQueue, TelemetryChannel

@evelyn-ys, please help verify if it can be bumped.

@jiasli jiasli requested a review from evelyn-ys March 8, 2022 08:17
@jiasli jiasli merged commit 56aa3c8 into Azure:dev Mar 9, 2022
@jiasli jiasli deleted the applicationinsights branch March 9, 2022 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot Packaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants