{Graph} Migrate command modules to use Microsoft Graph API #22361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
ghost
added
the
|
Graph |
jiasli
force-pushed
the
graph-migrate
branch
2 times, most recently
from
721da19 to
35af82c
Compare
jiasli
commented
May 12, 2022
| @@ -177,7 +177,7 @@ def create_resource(self, name, **kwargs): | |||
| pass | |||
|
|
|||
| if self.live_test or self.test_class_instance.in_recording: | |||
| sp_name = name | |||
| sp_name = self.result['appId'] | |||
There was a problem hiding this comment.
name is now only displayName of the app. It can no longer be used as an identifier for the service principal (#19892).
evelyn-ys
approved these changes
May 13, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
Migrate command modules to use Microsoft Graph API according to #22174