Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{Packaging} Bump Jinja2 to 3.0.3 #22602

Merged
merged 1 commit into from
May 25, 2022
Merged

{Packaging} Bump Jinja2 to 3.0.3 #22602

merged 1 commit into from
May 25, 2022

Conversation

kairu-ms
Copy link
Contributor

Related command

Description

Jinja2 below version 3 is not maintained. In version 3.0.3, it fixed bugs to support python 3.10 and 3.11.
The lastest version is 3.1.2, we cannot use this version because 3.1.x dropped python 3.6 support.

BTW, the version 3.0.3 already been applied in test_ref_doc.sh pipeline in #21798

Version 3.0.3 requires MarkupSafe>=2.0.
MarkupSafe 2.1.x drops python 3.6, so I bump it to version 2.0.1.

I've reviewed the usage of Jinja2 in our repo. It seems no code change required. But we still need to evaluate the impact on packaging pipeline.

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature


This checklist is used to make sure that common guidelines for a pull request are followed.

@ghost ghost requested a review from yonzhan May 25, 2022 03:36
@ghost ghost added the Auto-Assign Auto assign by bot label May 25, 2022
@ghost ghost assigned jiasli May 25, 2022
@ghost ghost added this to the Jun 2022 (2022-07-05) milestone May 25, 2022
@ghost ghost added the Packaging label May 25, 2022
@yonzhan
Copy link
Collaborator

yonzhan commented May 25, 2022

Packaging

@kairu-ms kairu-ms merged commit b33939c into Azure:dev May 25, 2022
@jiasli
Copy link
Member

jiasli commented May 25, 2022

Not being able to drop Python 3.6 is really a big problem (#19858). If CentOS 7 doesn't have Python 3.7+ support, we will have to drop CentOS 7 someday.

@bebound
Copy link
Contributor

bebound commented Nov 9, 2022

I find these two packages is not in setup.py, but some scripts use them. Actually they should be moved to requirements.dev.txt?

One interesting point is that alias extension rely on this commit. Otherwise its dependency Jinja2-2.11.3 is loaded and cannot import name 'soft_unicode' from 'markupsafe' raises.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot Packaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants