[Compute] Fix #23341: az vm list-skus: Fix filtering out VM sizes that are available regionally when they are restricted in all zones
#23457
Conversation
yanzhudd
requested review from
zhoxing-ms,
jsntcy and
wangzelin007
as code owners
ghost
requested a review
from 
ghost
added
the
|
Please add test case and rerun some tests like #18939 |
| if restriction['type'] == 'Location' and ( | ||
| result['locationInfo'][0]['location'] in (restriction['restrictionInfo']['locations'] or [])): | ||
| is_restrict_location = True | ||
| if is_restrict_zone and is_restrict_location: |
There was a problem hiding this comment.
I think it is possible for a VM sku to be restricted in region but not to have zonal restrictions listed. So I think the SKU should be considered restricted if it has a "Location" restriction OR all zones restricted.
There was a problem hiding this comment.
I think it is possible for a VM sku to be restricted in region but not to have zonal restrictions listed. So I think the SKU should be considered restricted if it has a "Location" restriction OR all zones restricted.
Thanks. We modified the code again according to your comment. Could you please help to confirm it again?
There was a problem hiding this comment.
I thought about this a bit more and think we may want to bring in Azure Compute team into conversation here to double-check.
If we are filtering out VM sizes from the list based on the restriction types, we may need to make the filtering logic also dependent on the --zone parameter which for this CLI command is described as "--zone: Show skus supporting availability zones. Allowed values: false, true"
I put together the following table to see if it makes sense to you and to Azure Compute:
| Restriction Types | VM SKU Availability | is_available? |
|---|---|---|
| Location=null, Zone=null | Yes, regional or any zone | TRUE |
| Location=null, Zone=1,2 | Yes, regional or zone 3 | TRUE |
| Location=null, Zone=1,2,3 | Yes, but only regional | if (--zone parameter) then FALSE else TRUE |
| Location=eastus2, Zone=null | No, since region is restricted all zones are restricted | FALSE |
| Location=eastus2, Zone=1,2 | No, since region is restricted all zones are restricted | FALSE |
| Location=eastus2, Zone=1,2,3 | No, since region is restricted all zones are restricted | FALSE |
There was a problem hiding this comment.
I thought about this a bit more and think we may want to bring in Azure Compute team into conversation here to double-check.
If we are filtering out VM sizes from the list based on the restriction types, we may need to make the filtering logic also dependent on the --zone parameter which for this CLI command is described as "--zone: Show skus supporting availability zones. Allowed values: false, true"
I put together the following table to see if it makes sense to you and to Azure Compute:
Restriction Types VM SKU Availability is_available?
Location=null, Zone=null Yes, regional or any zone TRUE
Location=null, Zone=1,2 Yes, regional or zone 3 TRUE
Location=null, Zone=1,2,3 Yes, but only regional if (--zone parameter) then FALSE else TRUE
Location=eastus2, Zone=null No, since region is restricted all zones are restricted FALSE
Location=eastus2, Zone=1,2 No, since region is restricted all zones are restricted FALSE
Location=eastus2, Zone=1,2,3 No, since region is restricted all zones are restricted FALSE
Hello @grizzlytheodore, could you please help to confirm this logic about filtering out VM sizes from the list based on the restriction types? Thanks.
Hello @chasewilson, if the relationship mentioned above is confirmed, we would modify the logic about filtering out VM sizes from the list based on the restriction types.
There was a problem hiding this comment.
I thought about this a bit more and think we may want to bring in Azure Compute team into conversation here to double-check.
If we are filtering out VM sizes from the list based on the restriction types, we may need to make the filtering logic also dependent on the --zone parameter which for this CLI command is described as "--zone: Show skus supporting availability zones. Allowed values: false, true"
I put together the following table to see if it makes sense to you and to Azure Compute:
Restriction Types VM SKU Availability is_available?
Location=null, Zone=null Yes, regional or any zone TRUE
Location=null, Zone=1,2 Yes, regional or zone 3 TRUE
Location=null, Zone=1,2,3 Yes, but only regional if (--zone parameter) then FALSE else TRUE
Location=eastus2, Zone=null No, since region is restricted all zones are restricted FALSE
Location=eastus2, Zone=1,2 No, since region is restricted all zones are restricted FALSE
Location=eastus2, Zone=1,2,3 No, since region is restricted all zones are restricted FALSE
@travismaier, could you please help to confirm this logic about filtering out VM sizes from the list based on the restriction types? Thanks.
|
Compute |
| # This SKU is not available only if zonal restriction and all zones are restricted | ||
| # and skus supporting availability zones are required to show | ||
| # or regional restriction and the region is restricted |
There was a problem hiding this comment.
Could you please refine this comment to make it more readable?
Description
In
az vm list-skuscommand, fix filtering out VM sizes that are available regionally when they are restricted in all zonesClose #23341
Testing Guide
History Notes
[Compute] Fix #23341:
az vm list-skus: Fix filtering out VM sizes that are available regionally when they are restricted in all zonesThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.