{CI} Add Test Rpm Package Mariner #25747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️acr
️✔️acs
️✔️advisor
️✔️ams
️✔️apim
️✔️appconfig
️✔️appservice
️✔️aro
️✔️backup
️✔️batch
️✔️batchai
️✔️billing
️✔️botservice
️✔️cdn
️✔️cloud
️✔️cognitiveservices
️✔️config
️✔️configure
️✔️consumption
️✔️container
️✔️core
️✔️cosmosdb
️✔️databoxedge
️✔️dla
️✔️dls
️✔️dms
️✔️eventgrid
️✔️eventhubs
️✔️feedback
️✔️find
️✔️hdinsight
️✔️identity
️✔️iot
️✔️keyvault
️✔️kusto
️✔️lab
️✔️managedservices
️✔️maps
️✔️marketplaceordering
️✔️monitor
️✔️netappfiles
️✔️network
️✔️policyinsights
️✔️privatedns
️✔️profile
️✔️rdbms
️✔️redis
️✔️relay
️✔️resource
️✔️role
️✔️search
️✔️security
️✔️servicebus
️✔️serviceconnector
️✔️servicefabric
️✔️signalr
️✔️sql
️✔️sqlvm
️✔️storage
️✔️synapse
️✔️telemetry
️✔️util
️✔️vm
|
ghost
added
ghost
requested review from
|
CI |
bebound
commented
Mar 10, 2023
|
|
||
| tdnf --nogpgcheck install /mnt/rpm/$RPM_NAME -y | ||
|
|
||
| tdnf install git gcc python3-devel python3-pip findutils -y |
There was a problem hiding this comment.
There are some differences with test_rpm_in_docker.sh
- Mariner does not install
pipwhen installpython3-devel. dnfbecomestdnf.- pip is also in
/usr/bin/by default.
I don't want to add the fifth env variables, so I create a new script for Mariner.
jiasli
reviewed
Mar 13, 2023
Comment on lines
+1
to
+10
| #!/usr/bin/env bash | ||
|
|
||
| # This script should be run in a centos7 docker. | ||
| set -exv | ||
|
|
||
| export USERNAME=azureuser | ||
|
|
||
| tdnf --nogpgcheck install /mnt/rpm/$RPM_NAME -y | ||
|
|
||
| tdnf install git gcc python3-devel python3-pip findutils -y |
There was a problem hiding this comment.
Can this script be reused from test_rpm_in_docker.sh by introducing some parameters?
There was a problem hiding this comment.
There are some differences between Mariner and UBI, see #25747 (comment).
Using same script decreases the duplicate code but increases the complexity of script.
We've used different dockerfile for Mariner and UBI. We can also use different test scripts.
jiasli
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Other builds have this test, add the same test for Mariner.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.