-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AKS] feat: Azure Monitor Metrics addon (v2) (Managed Prometheus) GA #26201
Conversation
️✔️AzureCLI-FullTest
|
AKS |
dce_name = get_default_dce_name(cmd, mac_region, cluster_name) | ||
dce_resource_id = "/subscriptions/{0}/resourceGroups/{1}/providers/Microsoft.Insights/dataCollectionEndpoints/{2}"\ | ||
.format(cluster_subscription, cluster_resource_group_name, dce_name) | ||
try: | ||
armendpoint = cmd.cli_ctx.cloud.endpoints.resource_manager | ||
dce_url = f"{armendpoint}{dce_resource_id}?api-version={DC_API}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question as above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_aks_commands.py
Show resolved
Hide resolved
Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com>
Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com>
…into kaveesh/ga_cli
Since your PR contains too much content, could you please refer to PR #25978 to write the descriptions of new commands and parameters into the |
I have updated the PR description following the pattern you described. |
@bragi92 Could you please resolve this CI issue? |
@zhoxing-ms I have fixed all the CI/CD issues and have tested out the changes locally on my test clusters and everything looks good to me. Please review it/merge it in if it looks good to you. |
@bragi92 I was looking for similar feature in azure sdk for go package. Is there plan to add it there. Meanwhile, can you please suggest any workaround for this? |
Related command
az aks update -n kaveeshcli22 -g kaveeshcli --enable-azure-monitor-metrics --enable-windows-recording-rules
az aks create -n kaveeshcli22 -g kaveeshcli --location westeurope --enable-azure-monitor-metrics --enable-windows-recording-rules --azure-monitor-workspace-resource-id "{full_id}" --grafana-resource-id "{full_id}"
Description
GA update for Azure Monitor Metrics. The changes for public preview where merged into the az cli extensions repo in the following PR: Azure/azure-cli-extensions#5428
Testing Guide
az aks create
andaz aks update
is being updated with the following parameters:To create a cluster with the Azure Monitor Metrics addon enabled and sending data to a particular Azure Monitor Workspace and linked with a Grafana instance run :
az aks create -n kaveeshcli1 -g kaveeshcli --location westeurope --enable-azure-monitor-metrics --azure-monitor-workspace-resource-id "{full_id}" --grafana-resource-id "{full_id}"
To update an existing cluster with the Azure Monitor Metrics addon to a default workspace and to enable windows recording rules on it run :
az aks update-n kaveeshcli2 -g kaveeshcli --enable-azure-monitor-metrics --enable-windows-recording-rules
To disable the Azure Monitor Metrics addon run :
az aks update-n kaveeshcli2 -g kaveeshcli --disable-azure-monitor-metrics
History Notes
[AKS]
az aks create/update
: Add parameter--enable-azure-monitor-metrics
to enable managed prometheus (Azure Monitor Metrics Addon)[AKS]
az aks create/update
: Add parameter--azure-monitor-workspace-resource-id
to store metrics for the managed prometheus addon[AKS]
az aks create/update
: Add parameter--grafana-resource-id
to link the Azure Monitor Workspace with a Grafana instance for viewing metrics and dashboards[AKS]
az aks create/update
: Add parameter--enable-windows-recording-rules
to enable windows recording rule groups on the Azure Monitor Workspace (by default they get created but are disabled)[AKS]
az aks create/update
: Add parameter--ksm-metric-labels-allow-list
to support the additional Kubernetes label keys that will be used in the resource' labels metric[AKS]
az aks create/update
: Add parameter--ksm-metric-annotations-allow-list
to support the Kubernetes annotations keys that will be used in the resource' labels metric[AKS]
az aks update
: Add parameter--disable-azure-monitor-metrics
to disable the Azure Monitor Metrics addonThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.