{Misc.} Remove all occurrences of assertDictContainsSubset #29121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onlined
requested review from
jiasli,
evelyn-ys,
jsntcy,
kairu-ms,
zhoxing-ms,
calvinhzy and
necusjz
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
Refactor |
microsoft-github-policy-service
bot
added
the
customer-reported
onlined
force-pushed
the
remove-assert-dict-contains-subset
branch
from
cc2a859
to
479e44e
Compare
|
@bebound Why was this put back into the backlog? It's not a breaking change. |
|
Sorry, we don't have the bandwidth to deal with Python 3.12-related PRs currently. |
|
Just a note: You don't need to deal with all Python 3.12-related PRs at once. If you merge trivial ones (maybe this is not, but #29120 definitely is) first, the work would be much easier in the future and it wouldn't feel huge. |
Indeed. The removal of
But the doc didn't mention the recommendation for I have verified using import unittest
a = {'a': 'b'}
b = {'a': 'b', 'c': 'd'}
class TestA(unittest.TestCase):
def test_dict(self):
self.assertDictContainsSubset(a, b)
self.assertLessEqual(a.items(), b.items())It'll be better to get Python developers' confirmation: python/cpython#28268 (comment). |
|
The |
jiasli
approved these changes
Jul 25, 2024
bebound
approved these changes
Jul 25, 2024
bebound
changed the title
bebound
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Python 3.12 removed
assertDictContainsSubset, so we are removing all usages by replacing it with subset assertion.This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.