{CI} Use MCR docker mirror #29304
Merged
{CI} Use MCR docker mirror #29304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
CI |
microsoft-github-policy-service
bot
requested review from
wangzelin007,
yonzhan,
jiasli,
kairu-ms,
jsntcy and
Pan-Qi
kairu-ms
approved these changes
Jul 3, 2024
bebound
commented
Jul 3, 2024
| @@ -323,6 +323,7 @@ jobs: | |||
| filePath: build_scripts\windows\scripts\test_zip_installation.ps1 | |||
|
|
|||
| - job: BuildDockerImageAlpine | |||
| continueOnError: true | |||
There was a problem hiding this comment.
By adding this, we can select the partially failed CI run in release pipeline.
jiasli
reviewed
Jul 3, 2024
| /bin/bash -c "cd /mnt/pypi && ls && pip install --find-links ./ azure_cli-$CLI_VERSION*whl && az self-test && az --version && sleep 5" | ||
|
|
||
| echo "== Testing pip install on Python 3.11 ==" | ||
| docker run \ | ||
| --rm -v $PYPI_FILES:/mnt/pypi python:3.11 \ | ||
| --rm -v $PYPI_FILES:/mnt/pypi mcr.microsoft.com/mirror/docker/library/python:3.11-slim \ |
There was a problem hiding this comment.
It looks like python:3.11 also exists and there is no need to change to python:3.11-slim:
https://mcr.microsoft.com/en-us/product/mirror/docker/library/python/tags
There was a problem hiding this comment.
3.9 does not exists. Adding -slim to make sure they share the same format.
There was a problem hiding this comment.
Well, MCR should contain python:3.9 as it is a popular image.
jiasli
approved these changes
Jul 3, 2024
evelyn-ys
approved these changes
Jul 3, 2024
calvinhzy
approved these changes
Jul 3, 2024
|
Ubuntu It is now available: https://mcr.microsoft.com/en-us/product/mirror/docker/library/ubuntu/tags
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use it to prevent the docker rate limit error: