[Packaging] Release Azure Linux 3 RPM package #29348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
Packaging |
microsoft-github-policy-service
bot
requested review from
jiasli,
wangzelin007 and
yonzhan
yonzhan
previously approved these changes
Jul 10, 2024
|
Azure Linux 3 uses Python 3.12. We need to resolve #27673 first. |
jiasli
reviewed
Jul 30, 2024
| @@ -21,8 +21,8 @@ COPY . . | |||
| RUN dos2unix ./scripts/release/rpm/azure-cli.spec && \ | |||
| REPO_PATH=$(pwd) CLI_VERSION=$cli_version PYTHON_PACKAGE=python3 PYTHON_CMD=python3 \ | |||
| rpmbuild -v -bb --clean scripts/release/rpm/azure-cli.spec && \ | |||
| cp /usr/src/mariner/RPMS/*/azure-cli-${cli_version}-1.*.rpm /azure-cli-dev.rpm && \ | |||
| mkdir /out && cp /usr/src/mariner/RPMS/*/azure-cli-${cli_version}-1.*.rpm /out/ | |||
| cp /usr/src/*/RPMS/*/azure-cli-${cli_version}-1.*.rpm /azure-cli-dev.rpm && \ | |||
There was a problem hiding this comment.
What is the new path on Azure Linux 3.0?
There was a problem hiding this comment.
/usr/src/azl/RPMS/x86_64/azure-cli-2.62.0-1.azl3.x86_64.rpm
There was a problem hiding this comment.
Let's add some example names in the comment.
jiasli
reviewed
Jul 30, 2024
| @@ -839,7 +841,7 @@ jobs: | |||
| set -ex | |||
|
|
|||
| CLI_VERSION=`cat $SYSTEM_ARTIFACTSDIRECTORY/metadata/version` | |||
| RPM_NAME=$(find $SYSTEM_ARTIFACTSDIRECTORY/rpm/ -type f -name "azure-cli-$CLI_VERSION-1.cm2.*.rpm" -printf '%f\n') | |||
| RPM_NAME=$(find $SYSTEM_ARTIFACTSDIRECTORY/rpm/ -type f -name "azure-cli-$CLI_VERSION-1.*.rpm" -printf '%f\n') | |||
There was a problem hiding this comment.
What will be the new package name?
There was a problem hiding this comment.
azure-cli-2.62.0-1.azl3.x86_64.rpm
There was a problem hiding this comment.
Can we add some example names to the comment, including both Mariner 2 and Azure Linux 3? This will increase the readability.
bebound
commented
Aug 2, 2024
| @@ -14,7 +14,7 @@ time az self-test | |||
| time az --version | |||
|
|
|||
| cd /azure-cli/ | |||
| pip install wheel | |||
| python -m pip install --upgrade pip setuptools | |||
There was a problem hiding this comment.
Previously, python3-setuptools package is installed by python3-devel package. The pip and setuptools are not latest version.
In Azure Linux 3, setuptools is not installed automatically. Use pip to explicitly install latest pip and setuptools
wheel is not a required package.
bebound
commented
Aug 2, 2024
| set -ev | ||
|
|
||
| export REPO_PATH=`cd $(dirname $0); cd ../../../; pwd` | ||
| rpmbuild -v -bb --clean $REPO_PATH/scripts/release/rpm/azure-cli.spec && cp /root/rpmbuild/RPMS/x86_64/* /mnt/output |
There was a problem hiding this comment.
This file is not used anymore.
|
PR title can be changed to
|
jiasli
reviewed
Aug 14, 2024
Co-authored-by: Jiashuo Li <4003950+jiasli@users.noreply.github.com>
bebound
changed the title
jiasli
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support Azure Linux 3
Resolve #29382