-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Drop old Track 2 SDK authentication support #29690
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Auth |
jiasli
changed the title
{Auth} Stop supporting old Track 2 SDKs
{Auth} Drop old Track 2 SDK authentication support
Aug 8, 2024
jiasli
changed the title
{Auth} Drop old Track 2 SDK authentication support
[Core] Drop old Track 2 SDK authentication support
Aug 8, 2024
jiasli
requested review from
evelyn-ys,
calvinhzy,
bebound,
jsntcy,
kairu-ms and
wangzelin007
as code owners
November 20, 2024 08:51
evelyn-ys
approved these changes
Nov 21, 2024
evelyn-ys
approved these changes
Dec 3, 2024
bebound
approved these changes
Dec 3, 2024
jsntcy
approved these changes
Dec 3, 2024
wangzelin007
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
Description
Resolve #20462
Track 2 SDKs generated before added --credential-scopes flag and scopes to config file autorest.python#239 don't maintain
credential_scopes
and callget_token
with empty scopes. As a workaround, returnNone
so that the CLI-managedresource
is used.Track 2 SDKs generated before Replace not extend scopes autorest.python#745 extend default
credential_scopes
with customcredential_scopes
. Instead,credential_scopes
should be replaced by customcredential_scopes
. As a workaround, remove the first one if there are multiple scopes provided.As CLI will no longer manage a
resource
after dropping Track 1 SDK support (#29631), this PR is a prerequisite.Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a
: Make some customer-facing breaking change[Component Name 2]
az command b
: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.