[Compute] az vmss create/update: Add --skuprofile-vmsizes and --skuprofile-allocation-strategy for Instance Mix
#29906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msdorahu
requested review from
zhoxing-ms,
jsntcy,
wangzelin007 and
yanzhudd
as code owners
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| vmss create | cmd vmss create added parameter skuprofile_allostrat |
||
| vmss create | cmd vmss create added parameter skuprofile_vmsizes |
||
| vmss update | cmd vmss update added parameter skuprofile_allostrat |
||
| vmss update | cmd vmss update added parameter skuprofile_vmsizes |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
Please note that Azure CLI will have a code freeze for the upcoming release on 09/24/2024 10:00 UTC. If you want to catch this release train, please address the comments and CI issues ASAP. Otherwise, it has to be postponed to next sprint (11-05). |
zhoxing-ms
modified the milestones:
September 2024 (2024-10-08),
October 2024 (2024-11-05)
msdorahu
force-pushed
the
origin/dev/dorahu/mixsku
branch
from
afe6094 to
1ad6fa8
Compare
msdorahu
changed the title
msdorahu
changed the title
zhoxing-ms
reviewed
Oct 8, 2024
zhoxing-ms
reviewed
Oct 8, 2024
zhoxing-ms
reviewed
Oct 9, 2024
src/azure-cli/azure/cli/command_modules/vm/tests/latest/test_vm_commands.py
Outdated
Show resolved
Hide resolved
zhoxing-ms
previously approved these changes
Oct 10, 2024
zhoxing-ms
changed the title
az vmss: Add skuprofile_vmsizes and skuprofile-allocation-strategy For Instance Mix
zhoxing-ms
changed the title
az vmss: Add skuprofile_vmsizes and skuprofile-allocation-strategy For Instance Mixaz vmss: Add skuprofile_vmsizes and skuprofile-allocation-strategy For Instance Mix
Please note that the |
|
@yanzhudd and @jsntcy and @wangzelin007 , this PR is still pending review from you, thanks! the build issue is an issue with the title content, I fixed it but I can't re-trigger the build |
zhoxing-ms
changed the title
az vmss: Add skuprofile_vmsizes and skuprofile-allocation-strategy For Instance Mixaz vmss create/update: Add --skuprofile-vmsizes and --skuprofile-allocation-strategy for Instance Mix
yanzhudd
reviewed
Oct 11, 2024
yanzhudd
reviewed
Oct 11, 2024
yanzhudd
reviewed
Oct 11, 2024
yanzhudd
reviewed
Oct 11, 2024
zhoxing-ms
approved these changes
Oct 14, 2024
yanzhudd
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
Description
This change adds skuprofile_vmsizes and skuprofile_allocation_strategy for vmss create and update
Testing Guide
vmss create -n vmssName -g rgName --image ubuntu2204 --vm-sku Mix --skuprofile-vmsizes Standard_DS1_v2 Standard_D2s_v4 --skuprofile-allocation-strategy CapacityOptimized
History Notes
[Compute]
az vmss create/update: Add new parameter--skuprofile-vmsizesto specify a list of VM sizes to use with VMSS Instance Mix[Compute]
az vmss create/update: Add new parameter--skuprofile-allocation-strategyto update the allocation strategy for VMSS Instance MixThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.