{RDBMS} az postgres flexible-server restore: Add empty string validation to resource group name
#29916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
|
Hi @mattboentoro, |
️✔️AzureCLI-BreakingChangeTest
|
|
RDBMS |
|
@yonzhan @evelyn-ys I recently joined PostgreSQL team, and this is my first PR on GitHub for RDBMS. I was wondering why I couldn't get to add my team member as a reviewer? Is there any other permission that I need to obtain for me to do that? In my last PR, one of my team member has to do it for me |
|
There's no special policy from our repo's settings. Maybe some restriction from Github |
nasc17
approved these changes
Sep 24, 2024
|
@evelyn-ys Please review this PR, looks good |
|
will review after current 10-08 release |
|
@yonzhan @evelyn-ys do you mind reviewing and merging this PR? |
evelyn-ys
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az postgres flexible-server restore
Description
Add empty string validation to resource group name for PG commands.
Testing Guide
Manual testing
History Notes
{RDBMS}
az postgres flexible-server restore: Add empty string validation to resource group nameThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.