Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SignalR] az signalr: Add subgroup command start, stop for azure signalr #30000

Merged
merged 3 commits into from
Oct 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions src/azure-cli/azure/cli/command_modules/signalr/_help.py
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,24 @@
az signalr list -g MySignalR -o table
"""

helps['signalr start'] = """
type: command
short-summary: Start an existing SignalR Service.
examples:
- name: Start a SignalR Service instance.
text: >
az signalr start -n MySignalR -g MyResourceGroup
"""

helps['signalr stop'] = """
type: command
short-summary: Stop an existing SignalR Service.
examples:
- name: Stop a SignalR Service instance.
text: >
az signalr stop -n MySignalR -g MyResourceGroup
"""

helps['signalr restart'] = """
type: command
short-summary: Restart an existing SignalR Service.
Expand Down
2 changes: 2 additions & 0 deletions src/azure-cli/azure/cli/command_modules/signalr/commands.py
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,8 @@ def load_command_table(self, _):
g.command('delete', 'signalr_delete')
g.command('list', 'signalr_list')
g.show_command('show', 'signalr_show', exception_handler=empty_on_404)
g.command('start', 'signalr_start', exception_handler=empty_on_404)
g.command('stop', 'signalr_stop', exception_handler=empty_on_404)
g.command('restart', 'signalr_restart', exception_handler=empty_on_404)
g.generic_update_command('update', getter_name='signalr_update_get',
setter_name='signalr_update_set', custom_func_name='signalr_update_custom',
Expand Down
12 changes: 12 additions & 0 deletions src/azure-cli/azure/cli/command_modules/signalr/custom.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
SignalRResource,
SignalRNetworkACLs)

from azure.mgmt.signalr.operations import SignalROperations


def signalr_create(client, signalr_name, resource_group_name,
sku, unit_count=1, location=None, tags=None, service_mode='Default', enable_message_logs=False, allowed_origins=None, default_action="Allow"):
Expand Down Expand Up @@ -44,6 +46,16 @@ def signalr_show(client, signalr_name, resource_group_name):
return client.get(resource_group_name, signalr_name)


def signalr_start(client: SignalROperations, signalr_name, resource_group_name):
parameter = SignalRResource(location=None, resource_stopped=False)
return client.begin_update(resource_group_name, signalr_name, parameter)


def signalr_stop(client: SignalROperations, signalr_name, resource_group_name):
parameter = SignalRResource(location=None, resource_stopped=True)
return client.begin_update(resource_group_name, signalr_name, parameter)


def signalr_restart(client, signalr_name, resource_group_name):
return client.begin_restart(resource_group_name, signalr_name)

Expand Down

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,23 @@ def test_signalr_commands(self, resource_group):
self.exists('externalIp'),
self.check('networkAcLs.defaultAction', '{default_action}')
])


# Test start
self.cmd('az signalr start -n {signalr_name} -g {rg}', checks=[
self.check('name', '{signalr_name}'),
self.check('location', '{location}'),
self.check('provisioningState', 'Succeeded'),
self.check('resourceStopped', 'false')
])

# Test stop
self.cmd('az signalr stop -n {signalr_name} -g {rg}', checks=[
self.check('name', '{signalr_name}'),
self.check('location', '{location}'),
self.check('provisioningState', 'Succeeded'),
self.check('resourceStopped', 'true')
])

# Test list
self.cmd('az signalr list -g {rg}', checks=[
self.check('[0].name', '{signalr_name}'),
Expand Down
2 changes: 1 addition & 1 deletion src/azure-cli/requirements.py3.Darwin.txt
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ azure-mgmt-servicefabric==2.1.0
azure-mgmt-servicefabricmanagedclusters==2.0.0b6
azure-mgmt-servicelinker==1.2.0b2
azure-mgmt-sql==4.0.0b19
azure-mgmt-signalr==2.0.0b1
azure-mgmt-signalr==2.0.0b2
azure-mgmt-sqlvirtualmachine==1.0.0b5
azure-mgmt-storage==21.2.0
azure-mgmt-synapse==2.1.0b5
Expand Down
2 changes: 1 addition & 1 deletion src/azure-cli/requirements.py3.Linux.txt
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ azure-mgmt-servicefabric==2.1.0
azure-mgmt-servicefabricmanagedclusters==2.0.0b6
azure-mgmt-servicelinker==1.2.0b2
azure-mgmt-sql==4.0.0b19
azure-mgmt-signalr==2.0.0b1
azure-mgmt-signalr==2.0.0b2
azure-mgmt-sqlvirtualmachine==1.0.0b5
azure-mgmt-storage==21.2.0
azure-mgmt-synapse==2.1.0b5
Expand Down
2 changes: 1 addition & 1 deletion src/azure-cli/requirements.py3.windows.txt
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ azure-mgmt-servicefabric==2.1.0
azure-mgmt-servicefabricmanagedclusters==2.0.0b6
azure-mgmt-servicelinker==1.2.0b2
azure-mgmt-sql==4.0.0b19
azure-mgmt-signalr==2.0.0b1
azure-mgmt-signalr==2.0.0b2
azure-mgmt-sqlvirtualmachine==1.0.0b5
azure-mgmt-storage==21.2.0
azure-mgmt-synapse==2.1.0b5
Expand Down
2 changes: 1 addition & 1 deletion src/azure-cli/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@
'azure-mgmt-servicefabricmanagedclusters==2.0.0b6',
'azure-mgmt-servicelinker==1.2.0b2',
'azure-mgmt-servicefabric~=2.1.0',
'azure-mgmt-signalr==2.0.0b1',
'azure-mgmt-signalr==2.0.0b2',
'azure-mgmt-sqlvirtualmachine==1.0.0b5',
'azure-mgmt-sql==4.0.0b19',
'azure-mgmt-storage==21.2.0',
Expand Down