{Redis} az redis update: Support --no-wait to avoid breaking change and default to True
#30035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| redis update | cmd redis update added parameter no_wait |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
bot
requested review from
evelyn-ys,
jsntcy,
yonzhan,
zhoxing-ms and
kairu-ms
microsoft-github-policy-service
bot
added
Redis Cache
Auto-Assign
koderjoker
changed the title
|
Please fix CI issues |
added 2 commits
October 8, 2024 14:15
evelyn-ys
previously approved these changes
Oct 9, 2024
evelyn-ys
approved these changes
Oct 9, 2024
evelyn-ys
changed the title
az redis update: Support --no-wait to avoid breaking change and default to True
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az redis update
Description
Resolves issue discussed here #24979 (comment)
Testing Guide
Examples:
az redis update -n {name} -g {rg} --set redisConfiguration.aadEnabled=true-az redis updateshould return without waiting for result of long running operationaz redis update -n {name} -g {rg} --set redisConfiguration.aadEnabled=false --no-wait False- option to wait for result of long running operation, for functional test usageThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.