{Network} az network dns record-set naptr: Naptr feature tests and fixes
#30055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WhiteHorseV
requested review from
jsntcy,
kairu-ms,
wangzelin007 and
necusjz
as code owners
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| network dns record-set naptr | sub group network dns record-set naptr added |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
bot
added
the
customer-reported
|
More changes to follow after the NAPTR feature is enabled in PPE/Prod when I can test the working. I will record the expected results after the feature is enabled. |
|
Please fix CI issues |
WhiteHorseV
changed the title
WhiteHorseV
changed the title
added 11 commits
October 31, 2024 12:07
djr-jsr
suggested changes
Nov 5, 2024
src/azure-cli/azure/cli/command_modules/network/tests/latest/test_dns_commands.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/network/zone_file/parse_zone_file.py
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/network/tests/latest/zone_files/zone10.txt
Outdated
Show resolved
Hide resolved
necusjz
changed the title
az network dns record-set naptr: Naptr feature tests and fixes
necusjz
approved these changes
Nov 25, 2024
yanzhudd
pushed a commit
to yanzhudd/azure-cli
that referenced
this pull request
Nov 25, 2024
…fixes (Azure#30055) * feature-naptr * NAPTR azcli small fixes * Naptr recordings * Fix len of tests * Naptr test fix for ttl comparison * Fix empty regexp test * Empty regexp fix * Fix the backslash expectations in regexp * Naptr empty regexp handling * Comment NS in tests * Style fixes * Naptr check fixes * More naptr regexp handling * naptr regexp handling * Change it to original values * NAPTR test updates and Zone import fixes * Naptr import/export logic fixes * Update with import zone recordings --------- Co-authored-by: Sandeep Kadagathur Vadiraj <skadagat@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.