{Pylint} Fix useless-object-inheritance #30331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atombrella
requested review from
zhoxing-ms,
jsntcy,
wangzelin007,
yanzhudd,
evelyn-ys,
calvinhzy,
jiasli,
kairu-ms,
necusjz and
bebound
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
bot
added
the
customer-reported
|
Thank you for your contribution atombrella! We will review the pull request and get back to you soon. |
jiasli
reviewed
Nov 13, 2024
| @@ -1593,7 +1593,7 @@ def _update_login(server_name, resource_group_name, auth_config, password_auth, | |||
|
|
|||
|
|
|||
| # pylint: disable=too-many-instance-attributes, too-few-public-methods, useless-object-inheritance | |||
There was a problem hiding this comment.
useless-object-inheritance can be removed.
Suggested change
| # pylint: disable=too-many-instance-attributes, too-few-public-methods, useless-object-inheritance | |
| # pylint: disable=too-many-instance-attributes, too-few-public-methods |
jiasli
reviewed
Nov 13, 2024
| @@ -1992,7 +1992,7 @@ def migrate_firewall_rules_from_single_to_flex(db_context, cmd, source_server_id | |||
|
|
|||
|
|
|||
| # pylint: disable=too-many-instance-attributes, too-few-public-methods, useless-object-inheritance | |||
There was a problem hiding this comment.
Suggested change
| # pylint: disable=too-many-instance-attributes, too-few-public-methods, useless-object-inheritance | |
| # pylint: disable=too-many-instance-attributes, too-few-public-methods |
jiasli
previously approved these changes
Nov 13, 2024
jiasli
changed the title
This is redundant as of Python 3.
atombrella
force-pushed
the
feature/no_object_import
branch
from
b0edaf3 to
0e603c2
Compare
|
@jiasli I pushed another small related fix. |
jiasli
approved these changes
Nov 15, 2024
bebound
changed the title
bebound
approved these changes
Nov 15, 2024
evelyn-ys
approved these changes
Nov 15, 2024
necusjz
approved these changes
Nov 15, 2024
zhoxing-ms
approved these changes
Nov 15, 2024
jiasli
changed the title
kairu-ms
approved these changes
Nov 20, 2024
kairu-ms
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is redundant as of Python 3. This code base needs a bit of cleaning after the Python 3 only support.
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.