{Pylint} Fix arguments-renamed #30345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
jiasli
changed the title
arguments-renamed pylint error
jiasli
requested review from
evelyn-ys,
jsntcy,
kairu-ms,
zhoxing-ms,
calvinhzy,
necusjz and
bebound
as code owners
12 tasks
jiasli
force-pushed
the
arguments-renamed
branch
from
fc328e5 to
e3d23b3
Compare
jiasli
commented
Dec 4, 2024
| @@ -60,22 +60,22 @@ class JsonBytearrayEncoder(json.JSONEncoder): | |||
| DATE_FORMAT = "%Y-%m-%d" | |||
| TIME_FORMAT = "%H:%M:%S" | |||
|
|
|||
| def default(self, obj): # pylint: disable=E0202,W0221 | |||
There was a problem hiding this comment.
W0221 is arguments-differ: https://pylint.readthedocs.io/en/latest/user_guide/messages/warning/arguments-differ.html
jiasli
commented
Dec 4, 2024
| @@ -365,8 +365,7 @@ def _ignore_if_not_registered(self, dest): | |||
| if not match: | |||
| super().argument(dest, arg_type=ignore_type) | |||
|
|
|||
| # pylint: disable=arguments-differ | |||
There was a problem hiding this comment.
Putting # pylint: disable=arguments-differ here is incorrect as it disables all arguments-differs below, including ignore(), not only for argument().
jiasli
force-pushed
the
arguments-renamed
branch
from
e3d23b3 to
034b615
Compare
jiasli
force-pushed
the
arguments-renamed
branch
from
034b615 to
3f1c8bc
Compare
jiasli
commented
Dec 4, 2024
Comment on lines
+469
to
+471
| def ignore(self, *args): # pylint: disable=arguments-differ | ||
| # It is expected that this method's signature differs from its base class, as it can be used to ignore | ||
| # multiple arguments in one method call. |
There was a problem hiding this comment.
Some examples:
bebound
approved these changes
Dec 5, 2024
evelyn-ys
approved these changes
Dec 9, 2024
evelyn-ys
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Finish the unfinished tasks of #20192
Fix
arguments-renamedpylint error.