{Pylint} Fix super-with-arguments #30367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ran this command ruff check . --select UP008 --unsafe-fixes --fix
These are not silenced with # pylint: disable=useless-super-delegation
atombrella
requested review from
zhoxing-ms,
jsntcy,
wangzelin007,
yanzhudd,
jiasli,
evelyn-ys,
calvinhzy,
kairu-ms,
bebound,
necusjz,
AllyW,
digimaun and
yonzhan
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
microsoft-github-policy-service
bot
added
the
customer-reported
|
Pylint |
3 tasks
atombrella
commented
Nov 15, 2024
| @@ -21,7 +21,7 @@ def __init__(self, cli_ctx=None): | |||
| synapse_custom = CliCommandType( | |||
| operations_tmpl='azure.cli.command_modules.synapse.custom#{}', | |||
| client_factory=cf_synapse_cl) | |||
| parent = super(SynapseManagementClientCommandsLoader, self) | |||
| parent = super() | |||
There was a problem hiding this comment.
I've seen this parent =super() a few times. I forgot to change it to super().__init__ here :/
necusjz
approved these changes
Nov 26, 2024
jiasli
approved these changes
Nov 26, 2024
evelyn-ys
approved these changes
Nov 26, 2024
wangzelin007
approved these changes
Nov 27, 2024
bebound
approved these changes
Nov 27, 2024
zhoxing-ms
approved these changes
Nov 27, 2024
calvinhzy
approved these changes
Nov 28, 2024
yanzhudd
approved these changes
Nov 28, 2024
jsntcy
approved these changes
Nov 28, 2024
kairu-ms
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Another thing that should be done. I found some weird
super().__init__(*args, **kwargs)and really don't see why they are there. Maybe they're auto-generated?I used:
ruff check . --select UP008 --unsafe-fixes --fixand manually fixed indentation of affected lines.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.