{Keyvault} az keyvault key show: Fix output format#31595
Merged
Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the output format for az keyvault key show by replacing the raw _attributes object with an explicit dictionary of attribute fields.
- Replaced
result.properties._attributeswith an explicit mapping of individual properties. - Removed attestation cleanup logic since attestation is no longer included.
- Adjusted output keys to match the expected CLI JSON schema.
Comments suppressed due to low confidence (2)
src/azure-cli/azure/cli/command_modules/keyvault/_transformers.py:125
- Add or update unit tests for
transform_key_outputto verify the new explicitattributesdictionary includes all expected fields and formats them correctly.
output = {
src/azure-cli/azure/cli/command_modules/keyvault/_transformers.py:122
- Update the function docstring for
transform_key_outputto describe the newly explicitattributesfields and their data types, so consumers and maintainers understand the output schema.
def transform_key_output(result, **command_args):
calvinhzy
approved these changes
Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
Fix #31529
This PR is just a workaround. We need SDK fix to better support us transforming SDK model to json dict Azure/azure-sdk-for-python#41261
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.