Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: CLI dies if output pipe is broken. #58 #61

Closed
wants to merge 2 commits into from
+9 −1
Closed

Fix: CLI dies if output pipe is broken. #58 #61

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe108d1
1. add SIGINT handler for Ctrl+C interruptions.
derekbekoe Mar 11, 2016
3b55062
Merge branch 'master' into fix-cli-sig
derekbekoe Mar 14, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/azure/cli/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,17 @@
import sys
import sys
import os
import signal

import azure.cli.main

from azure.cli._telemetry import init_telemetry, user_agrees_to_telemetry, telemetry_flush

signal.signal(signal.SIGINT, lambda signum, frame: sys.exit(1))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chatted offline. Conclusion is to use standard exceptions instead of registering signal handlers since that allows for having a more "normal" clean-up logic (i.e. try/finally)

We'll have to take differences in Python2 & 3 into account (ex. BrokenPipeException was introduced in 3.something)


if os.name != 'nt':
# can't call Windows with SIGPIPE
signal.signal(signal.SIGPIPE, lambda signum, frame: sys.exit(1))

try:
try:
if user_agrees_to_telemetry():
Expand Down