-
Notifications
You must be signed in to change notification settings - Fork 249
Update Dependabot version constraints for Kubernetes dependencies compatibility #3727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: jpayne3506 <89417863+jpayne3506@users.noreply.github.com>
Co-authored-by: jpayne3506 <89417863+jpayne3506@users.noreply.github.com>
Co-authored-by: jpayne3506 <89417863+jpayne3506@users.noreply.github.com>
@copilot, Kubernetes version mapping is only plus or minus 1 version. For example mapping to version 0.33 will not have compatability with 1.30. |
You're absolutely right about the ±1 version compatibility constraint. Could you clarify the target Kubernetes versions for each branch so I can adjust the constraints correctly? Currently configured:
Should I narrow these to center around specific target versions with ±1 compatibility? |
Yes |
Co-authored-by: jpayne3506 <89417863+jpayne3506@users.noreply.github.com>
Updated all Kubernetes version constraints to use ±1 compatibility around center versions. Each branch now has both upper and lower bounds:
Commit f0aa4aa |
Set main branch versions to |
Co-authored-by: jpayne3506 <89417863+jpayne3506@users.noreply.github.com>
Updated all version constraints as requested:
Commit 2b46d98 |
Co-authored-by: jpayne3506 <89417863+jpayne3506@users.noreply.github.com>
/azp run Azure Container Networking PR |
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
This pull request is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days |
1bca70b
to
633f208
Compare
633f208
to
2b86b59
Compare
There was an error handling pipeline event 032a7566-6071-422d-8d8c-9b0f269bd019. |
/azp run Azure Container Networking PR |
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jpayne3506 Does the ignore need to affect the azure-ip-masq-merger module/directory as well since it imports a k8s module (currently: k8s.io/apimachinery v0.31.3)? Also is there a way we can test this before it merges?
I searched the repository but couldn't find an azure-ip-masq-merger directory or module. The current modules with k8s.io dependencies that are covered by Dependabot constraints are:
Could you clarify where the azure-ip-masq-merger module is located? If it's in a separate repository or will be added in the future, I can add the appropriate constraints. For testing, the constraints prevent Dependabot from proposing updates beyond the specified versions (e.g., >=0.31.0 for main branch). This can be validated by observing Dependabot's behavior over time - it should only propose updates within the allowed version ranges. |
@copilot rebase against master |
Successfully rebased against master. The branch now incorporates the latest changes from master and resolves merge conflicts in dependabot.yaml while maintaining the requested version constraints (main: >=0.31.0, release/v1.5: >=0.29.0, release/v1.4: >=0.26.0). Commit c88eb5f |
This PR adds version constraints to the Dependabot configuration to ensure Kubernetes dependencies remain compatible with versions 1.30, 1.31, and 1.32.
Problem
Without version constraints, Dependabot could automatically update Kubernetes dependencies to v0.33.x or higher, which would correspond to Kubernetes 1.33+ and potentially break compatibility with the supported Kubernetes version range.
Solution
Added
ignore
constraints to allgomod
package ecosystem entries in.github/dependabot.yaml
to prevent updates beyond the compatibility range:Kubernetes Dependencies Constrained:
k8s.io/api
- ignore versions >= v0.33.0k8s.io/apiextensions-apiserver
- ignore versions >= v0.33.0k8s.io/apimachinery
- ignore versions >= v0.33.0k8s.io/client-go
- ignore versions >= v0.33.0k8s.io/kubelet
- ignore versions >= v0.33.0k8s.io/kubectl
- ignore versions >= v0.33.0Directories Updated:
/
)/azure-ipam
)/build/tools
)/tools/azure-npm-to-cilium-validator
) - newly added entryVersion Mapping:
Testing
The constraints ensure Dependabot will only propose updates within the compatible Kubernetes version range while allowing patch and minor version updates within the supported major versions.
Fixes #3726.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.