-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write to intermediate file before moving to state file #755
Conversation
Codecov Report
@@ Coverage Diff @@
## master #755 +/- ##
==========================================
+ Coverage 39.61% 41.36% +1.75%
==========================================
Files 82 142 +60
Lines 10800 13472 +2672
==========================================
+ Hits 4278 5573 +1295
- Misses 6017 7199 +1182
- Partials 505 700 +195 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments on the file flush, I'm not familiar with the other changes
platform/os.go
Outdated
return nil | ||
} | ||
|
||
isExist, _ := CheckIfFileExists(dirPath) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here...i can print err but i cannot validate error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checked this link: https://stackoverflow.com/questions/37932551/mkdir-if-not-exists-using-golang . let me validate error also and createdirectory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
followed up offline, approving invoker changes
@tamilmani1989 @ramiro-gamarra @matmerr When will the new Azure CNI version be released? One AKS Windows user hit the issue 3 times in one week that the Azure CNI file is invalid. |
@AbelHu We'd like to verify if this fix works. |
@zhiweiv We are working on this. We will try our best to update it in AKS ASAP. |
@zhiweiv azure cni v1.2.2 should be available in Azure global regions now. You can upgrade it by upgrading cluster or updating node images of Windows agent pools. |
Upgraded the problem AKS to lastest node image, it is azure cni 1.2.2 now. I will keep monitoring this issue. |
Reason for Change:
Write to intermediate file before moving to state file
Issue Fixed:
IP leak fixes
Ipam pool fixes
Requirements:
Notes: