PR comments

Azure · Nov 2, 2023 · 0e15171 · 0e15171
1 parent 2d13dfc
commit 0e15171
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/Microsoft.Azure.Cosmos/src/Linq/CosmosElementToSqlScalarExpressionVisitor.cs b/Microsoft.Azure.Cosmos/src/Linq/CosmosElementToSqlScalarExpressionVisitor.cs
@@ -6,6 +6,7 @@ namespace Microsoft.Azure.Cosmos.Linq
     using System;
     using System.Collections.Generic;
     using System.Collections.Immutable;
+    using System.Diagnostics;
     using Microsoft.Azure.Cosmos.CosmosElements;
     using Microsoft.Azure.Cosmos.CosmosElements.Numbers;
     using Microsoft.Azure.Cosmos.SqlObjects;
@@ -33,7 +34,8 @@ public SqlScalarExpression Visit(CosmosArray cosmosArray)
         public SqlScalarExpression Visit(CosmosBinary cosmosBinary)
         {
             // Can not convert binary to scalar expression without knowing the API type.
-            throw new NotImplementedException();
+            Debug.Fail("CosmosElementToSqlScalarExpressionVisitor Assert", "Unreachable");
+            throw new InvalidOperationException();
         }
 
         public SqlScalarExpression Visit(CosmosBoolean cosmosBoolean)
@@ -44,7 +46,8 @@ public SqlScalarExpression Visit(CosmosBoolean cosmosBoolean)
         public SqlScalarExpression Visit(CosmosGuid cosmosGuid)
         {
             // Can not convert guid to scalar expression without knowing the API type.
-            throw new NotImplementedException();
+            Debug.Fail("CosmosElementToSqlScalarExpressionVisitor Assert", "Unreachable");
+            throw new InvalidOperationException();
         }
 
         public SqlScalarExpression Visit(CosmosNull cosmosNull)

diff --git a/Microsoft.Azure.Cosmos/src/Linq/ExpressionToSQL.cs b/Microsoft.Azure.Cosmos/src/Linq/ExpressionToSQL.cs
@@ -1356,7 +1356,7 @@ private static SqlScalarExpression VisitScalarExpression(Expression expression,
 
                 ParameterExpression parameterExpression = context.GenFreshParameter(typeof(object), ExpressionToSql.DefaultParameterName);
                 SqlCollection subqueryCollection = ExpressionToSql.CreateSubquerySqlCollection(
-                    query, context,
+                    query,
                     isMinMaxAvgMethod ? SubqueryKind.ArrayScalarExpression : expressionObjKind.Value);
 
                 Binding newBinding = new Binding(parameterExpression, subqueryCollection,
@@ -1383,9 +1383,8 @@ private static SqlScalarExpression VisitScalarExpression(Expression expression,
         /// Create a subquery SQL collection object for a SQL query
         /// </summary>
         /// <param name="query">The SQL query object</param>
-        /// <param name="context">The translation context</param>
         /// <param name="subqueryType">The subquery type</param>
-        private static SqlCollection CreateSubquerySqlCollection(SqlQuery query, TranslationContext context, SubqueryKind subqueryType)
+        private static SqlCollection CreateSubquerySqlCollection(SqlQuery query, SubqueryKind subqueryType)
         {
             SqlCollection subqueryCollection;
             switch (subqueryType)

diff --git a/Microsoft.Azure.Cosmos/src/Linq/ICosmosLinqSerializer.cs b/Microsoft.Azure.Cosmos/src/Linq/ICosmosLinqSerializer.cs
@@ -21,7 +21,7 @@ internal interface ICosmosLinqSerializer
         SqlScalarExpression ConvertToSqlScalarExpression(ConstantExpression inputExpression, IDictionary<object, string> parameters);
 
         /// <summary>
-        /// Gets a member name with any LINQ serializer options applied.
+        /// Gets a member name with LINQ serializer options applied.
         /// </summary>
         string GetMemberName(MemberInfo memberInfo, CosmosLinqSerializerOptions linqSerializerOptions = null);
     }