Use static readonly arrays for separators

Azure · Dec 23, 2024 · 74eede4 · 74eede4
1 parent a5469f2
commit 74eede4
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 6 deletions.
diff --git a/Microsoft.Azure.Cosmos/src/DocumentClient.cs b/Microsoft.Azure.Cosmos/src/DocumentClient.cs
@@ -1410,6 +1410,10 @@ public void Dispose()
 
         internal virtual Task<QueryPartitionProvider> QueryPartitionProvider => this.queryPartitionProvider.Value;
 
+        private static readonly char[] databaseLinkSeparators = new char[] { '/' };
+        private static readonly char[] sourceDocumentCollectionLinkSeparators = new char[] { '/' };
+        private static readonly char[] resourceIdSeparators = new char[] { '/', '\\', '?', '#' };
+
         internal virtual async Task<ConsistencyLevel> GetDefaultConsistencyLevelAsync()
         {
             await this.EnsureValidClientAsync(NoOpTrace.Singleton);
@@ -2165,7 +2169,7 @@ private async Task<ResourceResponse<DocumentCollection>> RestoreDocumentCollecti
             string databaseLink = PathsHelper.GetDatabasePath(sourceDocumentCollectionLink);
             if (PathsHelper.TryParsePathSegments(databaseLink, out isFeed, out resourceTypeString, out resourceIdOrFullName, out isNameBased) && isNameBased && !isFeed)
             {
-                string[] segments = resourceIdOrFullName.Split(new char[] { '/' }, StringSplitOptions.RemoveEmptyEntries);
+                string[] segments = resourceIdOrFullName.Split(databaseLinkSeparators, StringSplitOptions.RemoveEmptyEntries);
                 dbsId = segments[segments.Length - 1];
             }
             else
@@ -2176,7 +2180,7 @@ private async Task<ResourceResponse<DocumentCollection>> RestoreDocumentCollecti
             string sourceCollId;
             if (PathsHelper.TryParsePathSegments(sourceDocumentCollectionLink, out isFeed, out resourceTypeString, out resourceIdOrFullName, out isNameBased) && isNameBased && !isFeed)
             {
-                string[] segments = resourceIdOrFullName.Split(new char[] { '/' }, StringSplitOptions.RemoveEmptyEntries);
+                string[] segments = resourceIdOrFullName.Split(sourceDocumentCollectionLinkSeparators, StringSplitOptions.RemoveEmptyEntries);
                 sourceCollId = segments[segments.Length - 1];
             }
             else
@@ -6811,7 +6815,7 @@ internal void ValidateResource(string resourceId)
         {
             if (!string.IsNullOrEmpty(resourceId))
             {
-                int match = resourceId.IndexOfAny(new char[] { '/', '\\', '?', '#' });
+                int match = resourceId.IndexOfAny(resourceIdSeparators);
                 if (match != -1)
                 {
                     throw new ArgumentException(string.Format(

diff --git a/Microsoft.Azure.Cosmos/src/Linq/ExpressionToSQL.cs b/Microsoft.Azure.Cosmos/src/Linq/ExpressionToSQL.cs
@@ -1525,7 +1525,7 @@ internal static SqlScalarExpression VisitScalarExpression(Expression expression,
         {
             return ExpressionToSql.VisitScalarExpression(
                 expression,
-                new ReadOnlyCollection<ParameterExpression>(new ParameterExpression[] { }),
+                new ReadOnlyCollection<ParameterExpression>(Array.Empty<ParameterExpression>()),
                 context);
         }
 

diff --git a/Microsoft.Azure.Cosmos/src/Routing/LocationHelper.cs b/Microsoft.Azure.Cosmos/src/Routing/LocationHelper.cs
@@ -10,6 +10,8 @@ namespace Microsoft.Azure.Cosmos.Routing
     /// </summary>
     internal static class LocationHelper
     {
+        private static readonly char[] hostSeparators = new char[] { '.' };
+
         /// <summary>
         /// For example, for https://contoso.documents.azure.com:443/ and "West US", this will return https://contoso-westus.documents.azure.com:443/
         /// NOTE: This ONLY called by client first boot when the input endpoint is not available.
@@ -21,7 +23,7 @@ internal static Uri GetLocationEndpoint(Uri serviceEndpoint, string location)
             // Split the host into 2 parts seperated by '.'
             // For example, "contoso.documents.azure.com" is separated into "contoso" and "documents.azure.com"
             // If the host doesn't contains '.', this will return the host as is, as the only element
-            string[] hostParts = builder.Host.Split(new char[] { '.' }, 2);
+            string[] hostParts = builder.Host.Split(hostSeparators, 2);
 
             if (hostParts.Length != 0)
             {

diff --git a/Microsoft.Azure.Cosmos/src/Telemetry/Collector/TelemetryCollector.cs b/Microsoft.Azure.Cosmos/src/Telemetry/Collector/TelemetryCollector.cs
@@ -15,6 +15,7 @@ internal class TelemetryCollector : ITelemetryCollector
     {
         private readonly ClientTelemetry clientTelemetry = null;
         private readonly ConnectionPolicy connectionPolicy = null;
+        private static readonly char[] pathSeparators = new char[] { '/' };
 
         internal TelemetryCollector(
             ClientTelemetry clientTelemetry,
@@ -69,7 +70,7 @@ public void CollectOperationAndNetworkInfo(Func<TelemetryInformation> functionFo
 
         private static void GetDatabaseAndCollectionName(string path, out string databaseName, out string collectionName)
         {
-            string[] segments = path.Split(new char[] { '/' }, StringSplitOptions.RemoveEmptyEntries);
+            string[] segments = path.Split(pathSeparators, StringSplitOptions.RemoveEmptyEntries);
 
             PathsHelper.ParseDatabaseNameAndCollectionNameFromUrlSegments(segments, out databaseName, out collectionName);
         }