Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UserAgent: Remove direct version #3160

Closed
j82w opened this issue Apr 25, 2022 · 1 comment · Fixed by #3173
Closed

UserAgent: Remove direct version #3160

j82w opened this issue Apr 25, 2022 · 1 comment · Fixed by #3173
Labels
feature-request New feature or request

Comments

@j82w
Copy link
Contributor

j82w commented Apr 25, 2022

The direct version should not be included in the .NET v3 user agent. The direct is not done via a nuget reference so it is not necessary. This has caused a lot of confusion for customers and has not been used in any scenarios.

Current example:
cosmos-netstandard-sdk/3.26.1|3.27.2|1|X64|Microsoft Windows 10.0.22000|.NET 6.0.4|N|

The 3.27.1 should be removed. This can also be figured out from the release branch.
Updated:
cosmos-netstandard-sdk/3.26.1|1|X64|Microsoft Windows 10.0.22000|.NET 6.0.4|N|
@j82w j82w added the feature-request New feature or request label Apr 25, 2022
@j82w
Copy link
Contributor Author

j82w commented May 3, 2022

Needs to be removed from: https://github.com/Azure/azure-cosmos-dotnet-v3/blob/master/Microsoft.Azure.Cosmos/src/UserAgentContainer.cs

@imanvt imanvt linked a pull request May 5, 2022 that will close this issue
UserAgent: Removes direct version #3173
Merged
@imanvt imanvt mentioned this issue May 5, 2022
Merged
@j82w j82w closed this as completed in #3173 May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

UserAgent: Removes direct version Azure/azure-cosmos-dotnet-v3
1 participant
@j82w