-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UserAgent: Removes direct version #3173
UserAgent: Removes direct version #3173
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors|Removes) Description"
Internal should be used for PRs that have no customer impact. This flag is used to help generate the changelog to know which PRs should be included. Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/UserAgentTests.cs
Outdated
Show resolved
Hide resolved
The user agent still has the SDK version. The direct version can be found by looking it up in the github branches. There is a branch for every release. |
Should we make it part of our changelog? that will make life easier instead of searching for it in the branch |
It's very rare that we need to know the direct version. I don't think we need to log it in the changelog, and it's not something customer should know or care about. |
Pull Request Template
Description
Remove direct version from user agent to as it is unnecessary. The direct version dll is copied into the nuget folder rather than being referenced as a nuget so customers can not change it.
Type of change
Closing issues
closes #3160