Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PartitionKeyRangeCacheTests are flaky #4732

Closed
neildsh opened this issue Sep 27, 2024 · 5 comments · Fixed by #4761
Closed

PartitionKeyRangeCacheTests are flaky #4732

neildsh opened this issue Sep 27, 2024 · 5 comments · Fixed by #4761
Assignees
@sourabh1007
Labels
needs-investigation

Comments

@neildsh
Copy link
Contributor

neildsh commented Sep 27, 2024

ClientTelemetryTestsBase has logic that is timing dependent. This causes the tests to be flaky.
Ideally, the VerifyPkRangeCacheRefreshOnSplitWithErrorsAsync method should be rewritten to correct these deficiencies.

To Reproduce
This reproduces in the PR builds.

Expected behavior
Tests should not use calls to Task.Delay. The outcome of a test should be deterministic.
@kirankumarkolli
Copy link
Member

@sourabh1007 can you please look into it?

@Pilchie
Copy link
Member

Pilchie commented Sep 30, 2024

👀

@Pilchie
Copy link
Member

Pilchie commented Sep 30, 2024

If we can't prioritize this and identify a fix within this week, we should disable these tests until we can. It unduly impacts the productivity of the entire team.

@kirankumarkolli
Copy link
Member

This is on a critical path of caches, lets look into it.
Would be a good learning exercises for he new hires forward.

@sourabh1007
Copy link
Contributor

If I am not wrong, it has nothing to do with client telemetry. It is just another test depending on Task.Delay which is flaky. Or I am missing something here.

@sourabh1007 sourabh1007 mentioned this issue Oct 8, 2024
Merged
kirankumarkolli pushed a commit that referenced this issue Oct 8, 2024
@sourabh1007
[Internal] Flaky Test: Fixes PartitionKeyRangeCacheTests (#4761)
f3e343c 
## Description

Removing dependency on `Task.Delay() `

## Type of change
- [] Bug fix (non-breaking change which fixes an issue)

## Closing issues

To automatically close an issue: closes #4732
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sourabh1007 sourabh1007

Labels
needs-investigation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Internal] Flaky Test: Fixes PartitionKeyRangeCacheTests Azure/azure-cosmos-dotnet-v3
4 participants
@Pilchie @sourabh1007 @kirankumarkolli @neildsh