Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PortReuseMode to CosmosClientOptions #1000

Merged
merged 7 commits into from
Nov 20, 2019
Merged

Add PortReuseMode to CosmosClientOptions #1000

merged 7 commits into from
Nov 20, 2019

Conversation

ausfeldt
Copy link
Contributor

@ausfeldt ausfeldt commented Nov 15, 2019 •
edited
Loading

Description

Add PortReuseMode to CosmosClientOptions.

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@ausfeldt ausfeldt requested a review from kirillg as a code owner November 15, 2019 04:16
@ausfeldt ausfeldt self-assigned this Nov 15, 2019
j82w
j82w reviewed Nov 19, 2019
View reviewed changes
changelog.md Outdated Show resolved Hide resolved
j82w
j82w reviewed Nov 19, 2019
View reviewed changes
changelog.md.orig Outdated Show resolved Hide resolved
@kirankumarkolli kirankumarkolli merged commit 101679f into master Nov 20, 2019
@kirankumarkolli kirankumarkolli deleted the users/gaausfel/add_portReuseMode branch November 20, 2019 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j82w j82w j82w approved these changes

@kirankumarkolli kirankumarkolli kirankumarkolli left review comments

@ealsur ealsur Awaiting requested review from ealsur

@kirillg kirillg Awaiting requested review from kirillg kirillg is a code owner

Assignees

@ausfeldt ausfeldt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ausfeldt @kirankumarkolli @j82w