-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ThroughputResponse.IsReplacePending #1023
Merged
kirankumarkolli
merged 5 commits into
Azure:master
from
wahyuen:users/wahyuen/isreplacepending
Nov 20, 2019
Merged
Fix ThroughputResponse.IsReplacePending #1023
kirankumarkolli
merged 5 commits into
Azure:master
from
wahyuen:users/wahyuen/isreplacepending
Nov 20, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix the value that is being retrieved when mapping ThoughputResponse.IsReplacePending
j82w
reviewed
Nov 19, 2019
…ahyuen/azure-cosmos-dotnet-v3 into users/wahyuen/isreplacepending
j82w
previously approved these changes
Nov 19, 2019
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
kirankumarkolli
previously approved these changes
Nov 19, 2019
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
j82w
approved these changes
Nov 20, 2019
kirankumarkolli
approved these changes
Nov 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix the value that is being retrieved when mapping ThoughputResponse.IsReplacePending
Pull Request Template
Description
This PR is to fix the value that is being retrieved when mapping ThoughputResponse.IsReplacePending as it is currently incorrectly attempting to read
WFConstants.BackendHeaders.MinimumRUsForOffer
Type of change
Please delete options that are not relevant.
Closing issues
Closes #1024