CreateItem will only retry for auto-extracted partition key in-case of container re-creation #1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…request would be sent twice. The retry logic for the partition key extraction was always being used if it was a user provided partition key value or an extracted partition key value. The retry logic should only be used for SDK extracted partition key value in scenarios where the cache is stale.
j82w
changed the title
ealsur
reviewed
Dec 2, 2019
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/NameRoutingTests.cs
Outdated
Show resolved
Hide resolved
ealsur
previously approved these changes
Dec 2, 2019
…sts/NameRoutingTests.cs Co-Authored-By: Matias Quaranta <ealsur@users.noreply.github.com>
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/NameRoutingTests.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Utils/CustomHandler.cs
Outdated
Show resolved
Hide resolved
| Container container = await database.CreateContainerAsync(id: "coll1", partitionKeyPath: "/doesnotexist"); | ||
| ToDoActivity toDoActivity = ToDoActivity.CreateRandomToDoActivity(); | ||
|
|
||
| ItemResponse<ToDoActivity> response = await container.CreateItemAsync(toDoActivity, partitionKey: new Cosmos.PartitionKey(toDoActivity.status)); |
There was a problem hiding this comment.
Test for other case where retry are expected?
There was a problem hiding this comment.
The test above this is testing the happy path. This test is for specifically testing that if a user provides a partition key value it is not retried on.
j82w
commented
Dec 2, 2019
j82w
changed the title
kirankumarkolli
approved these changes
Dec 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Fixed bug where if a user provided the wrong partition key value the request would be sent twice. The retry logic for the partition key extraction was always being used if it was a user provided partition key value or an extracted partition key value. The retry logic should only be used for SDK extracted partition key value in scenarios where the cache is stale.
Type of change
Please delete options that are not relevant.