SynchronizationContext and blocking calls #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j82w
reviewed
Dec 5, 2019
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests.NETFX/Utils/TestCommon.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Resource/Container/ContainerCore.Items.cs
Outdated
Show resolved
Hide resolved
j82w
previously approved these changes
Dec 5, 2019
|
One alternative possible design is to have a wrapper implementation which will handle this specific concern. #Closed |
kirankumarkolli
requested changes
Dec 6, 2019
Microsoft.Azure.Cosmos/src/Resource/Conflict/ConflictsInlineCore.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Resource/Container/ContainerCore.Items.cs
Outdated
Show resolved
Hide resolved
kirankumarkolli
previously approved these changes
Dec 9, 2019
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
In scenarios where there is a SynchronizationContext (Windows Forms, ASP.NET on .NET Framework) and the SDK is used in a blocking way (through
ConfigureAwait(false).GetAwaiter().GetResult()), the operation needs to be launched through aTask.Runto avoid a deadlock on the SynchronizationContext.This PR creates Inline versions of: ContainerCore, UserCore, DatabaseCore, PermissionCore, ConflictsCore, ScriptsCore that wrap calls in a new TaskHelper to detect the need of
Task.Run.Type of change
Closing issues
Closes #1043