Fixed public properties to have same JSON attributes #1112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…system types. PermissionProperties is now modified to be nullable to match the rest of the resource types.
j82w
added
bug
j82w
changed the title
ealsur
reviewed
Dec 19, 2019
Microsoft.Azure.Cosmos/src/Resource/Settings/PermissionProperties.cs
Outdated
Show resolved
Hide resolved
| @@ -35,23 +35,23 @@ public class ThroughputProperties | |||
| /// <remarks> | |||
| /// ETags are used for concurrency checking when updating resources. | |||
| /// </remarks> | |||
| [JsonProperty(PropertyName = Constants.Properties.ETag)] | |||
| [JsonProperty(PropertyName = Constants.Properties.ETag, NullValueHandling = NullValueHandling.Ignore)] | |||
There was a problem hiding this comment.
Is this breaking today? or what's the reason to add the NullValueHandling?
There was a problem hiding this comment.
Half of the properties have the ignore the other don't. It seems like making it consistent between all the types was missed. Serializing a null _etag or other system properties and sending it to the backend only increase payload size and has no benefit.
kirankumarkolli
approved these changes
Dec 30, 2019
kirankumarkolli
previously approved these changes
Jan 14, 2020
kirillg
previously approved these changes
Jan 21, 2020
added 5 commits
January 21, 2020 06:15
…com/Azure/azure-cosmos-dotnet-v3 into users/jawilley/bug/lastmodifiedtime
ealsur
previously approved these changes
Jan 21, 2020
ealsur
approved these changes
Jan 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
This fixes all the public properties to have the same JSON attributes for the same public property like etag.
Type of change
Please delete options that are not relevant.
Closing issues
closes #1111