CosmosClientSideRequestStatistics merged into DiagnosticContext #1189

j82w · 2020-01-31T21:24:12Z

Pull Request Template

Description

AddressResolutionStatistics and StoreResponseStatistics are now merged into the diagnostic context list. This allows the results to be shown in order with the other context information rather than a single aggregated result. This allows to see which retry has which AddressResolutionStatistics and StoreResponseStatistics.

CosmosClientSideRequestStatistics is added to the context a single time to avoid duplicating the same data for multiple retries.

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

Example:

// Success scenario

{
    "Summary": {
        "StartUtc": "2020-02-21T15:49:11.4406660Z",
        "ElapsedTime": "00:00:00.1437418",
        "UserAgent": "cosmos-netstandard-sdk/3.7.0|3.7.0|02852|X64|Microsoft Windows 10.0.18363 |.NET Core 4.6.28008.01|",
        "TotalRequestCount": 0,
        "FailedRequestCount": 0
    },
    "Context": [
        {
            "Id": "ItemStream",
            "ElapsedTime": "00:00:00.1437418"
        },
        {
            "Id": "ItemSerialize",
            "ElapsedTime": "00:00:00.0000771"
        },
        {
            "Id": "ExtractPkValue",
            "ElapsedTime": "00:00:00.0331291"
        },
        {
            "Id": "ProcessItemStream",
            "ElapsedTime": "00:00:00.1105283"
        },
        {
            "Id": "RequestInvokerHandler",
            "ElapsedTime": "00:00:00.1105209"
        },
        {
            "Id": "AggregatedClientSideRequestStatistics",
            "ContactedReplicas": [
                {
                    "Count": 12,
                    "Uri": "rntbd://127.0.0.1:10253/apps/DocDbApp/services/DocDbServer9/partitions/a4cb4955-38c8-11e6-8106-8cdcd42c33be/replicas/1p/"
                }
            ],
            "RegionsContacted": [
                "https://127.0.0.1:8081/"
            ],
            "FailedReplicas": []
        },
        {
            "Id": "Microsoft.Azure.Cosmos.Handlers.RetryHandler",
            "ElapsedTime": "00:00:00.1104252"
        },
        {
            "Id": "Microsoft.Azure.Cosmos.Handlers.RouterHandler",
            "ElapsedTime": "00:00:00.1104069"
        },
        {
            "Id": "TransportHandler",
            "ElapsedTime": "00:00:00.1104029"
        },
        {
            "Id": "AddressResolutionStatistics",
            "StartTimeUtc": "2020-02-21T15:49:11.5386270Z",
            "EndTimeUtc": "2020-02-21T15:49:11.5592235Z",
            "TargetEndpoint": "https://127.0.0.1:8081//addresses/?$resolveFor=dbs%2fzY8aAA%3d%3d%2fcolls%2fzY8aAIs6Sh0%3d%2fdocs&$filter=protocol eq rntbd&$partitionKeyRangeIds=0"
        },
        {
            "Id": "StoreResponseStatistics",
            "ResponseTimeUtc": "2020-02-21T15:49:11.5816214Z",
            "ResourceType": 2,
            "OperationType": 0,
            "LocationEndpoint": "https://127.0.0.1:8081/",
            "StoreResult": "StorePhysicalAddress: rntbd://127.0.0.1:10253/apps/DocDbApp/services/DocDbServer9/partitions/a4cb4955-38c8-11e6-8106-8cdcd42c33be/replicas/1p/, LSN: 1350, GlobalCommittedLsn: -1, PartitionKeyRangeId: 0, IsValid: True, StatusCode: 201, SubStatusCode: 0, RequestCharge: 11.05, ItemLSN: -1, SessionToken: -1#1350, UsingLocalLSN: False, TransportException: null"
        }
    ]
}

Request To large:

{
    "Summary": {
        "StartUtc": "2020-02-21T15:57:48.1673313Z",
        "ElapsedTime": "00:00:00.7950596",
        "UserAgent": "cosmos-netstandard-sdk/3.7.0|3.7.0|08204|X64|Microsoft Windows 10.0.18363 |.NET Core 4.6.28008.01|",
        "TotalRequestCount": 1,
        "FailedRequestCount": 1
    },
    "Context": [
        {
            "Id": "ProcessItemStream",
            "ElapsedTime": "00:00:00.7950596"
        },
        {
            "Id": "RequestInvokerHandler",
            "ElapsedTime": "00:00:00.7950496"
        },
        {
            "Id": "AggregatedClientSideRequestStatistics",
            "ContactedReplicas": [
                {
                    "Count": 12,
                    "Uri": "rntbd://127.0.0.1:10253/apps/DocDbApp/services/DocDbServer4/partitions/a4cb4950-38c8-11e6-8106-8cdcd42c33be/replicas/1p/"
                }
            ],
            "RegionsContacted": [],
            "FailedReplicas": []
        },
        {
            "Id": "Microsoft.Azure.Cosmos.Handlers.RetryHandler",
            "ElapsedTime": "00:00:00.7949887"
        },
        {
            "Id": "Microsoft.Azure.Cosmos.Handlers.RouterHandler",
            "ElapsedTime": "00:00:00.7909275"
        },
        {
            "Id": "TransportHandler",
            "ElapsedTime": "00:00:00.7909111"
        },
        {
            "Id": "PointOperationStatistics",
            "ActivityId": "bc86cef0-722a-4245-ae34-94989a90031e",
            "ResponseTimeUtc": "2020-02-21T15:57:48.9581465Z",
            "StatusCode": 413,
            "SubStatusCode": 0,
            "RequestCharge": 0.0,
            "RequestUri": "dbs/555d597a-6895-4bb3-9607-56ec4e3c3cc0/colls/a1242f0f-4b1b-4751-9615-ac3b3c050f35",
            "ErrorMessage": "Message: {\"Errors\":[\"Request size is too large\"]}\r\nActivityId: bc86cef0-722a-4245-ae34-94989a90031e",
            "RequestSessionToken": null,
            "ResponseSessionToken": null
        }
    ]
}

Failed with 429s:

{
    "Summary": {
        "StartUtc": "2020-02-21T16:15:22.5800160Z",
        "ElapsedTime": "00:00:05.3662161",
        "UserAgent": "cosmos-netstandard-sdk/3.7.0|3.7.0|99290|X64|Microsoft Windows 10.0.18363 |.NET Core 4.6.28008.01|",
        "TotalRequestCount": 10,
        "FailedRequestCount": 10
    },
    "Context": [
        {
            "Id": "RequestInvokerHandler",
            "ElapsedTime": "00:00:05.3662161"
        },
        {
            "Id": "AggregatedClientSideRequestStatistics",
            "ContactedReplicas": [
                {
                    "Count": 10,
                    "Uri": "rntbd://127.0.0.1:10253/apps/DocDbApp/services/DocDbServer18/partitions/a4cb495e-38c8-11e6-8106-8cdcd42c33be/replicas/1p/"
                }
            ],
            "RegionsContacted": [
                "https://127.0.0.1:8081/"
            ],
            "FailedReplicas": []
        },
        {
            "Id": "Microsoft.Azure.Cosmos.Handlers.RetryHandler",
            "ElapsedTime": "00:00:05.3661548"
        },
        {
            "Id": "Microsoft.Azure.Cosmos.Handlers.RouterHandler",
            "ElapsedTime": "00:00:00.0175562"
        },
        {
            "Id": "Microsoft.Azure.Cosmos.Handlers.PartitionKeyRangeGoneRetryHandler",
            "ElapsedTime": "00:00:00.0136554"
        },
        {
            "Id": "Microsoft.Azure.Cosmos.Handlers.PartitionKeyRangeHandler",
            "ElapsedTime": "00:00:00.0056213"
        },
        {
            "Id": "Microsoft.Azure.Cosmos.Handlers.TransportHandler",
            "ElapsedTime": "00:00:00.0049396"
        },
        {
            "Id": "TransportHandler",
            "ElapsedTime": "00:00:00.0049286"
        },
        {
            "Id": "StoreResponseStatistics",
            "ResponseTimeUtc": "2020-02-21T16:15:22.5843229Z",
            "ResourceType": "Document",
            "OperationType": "ReadFeed",
            "LocationEndpoint": "https://127.0.0.1:8081/",
            "StoreResult": "StorePhysicalAddress: rntbd://127.0.0.1:10253/apps/DocDbApp/services/DocDbServer18/partitions/a4cb495e-38c8-11e6-8106-8cdcd42c33be/replicas/1p/, LSN: 593, GlobalCommittedLsn: -1, PartitionKeyRangeId: , IsValid: True, StatusCode: 429, SubStatusCode: 3200, RequestCharge: 0.38, ItemLSN: -1, SessionToken: -1#593, UsingLocalLSN: True, TransportException: null"
        },
        {
            "Id": "Microsoft.Azure.Cosmos.Handlers.RouterHandler",
            "ElapsedTime": "00:00:00.0066013"
        },
        {
            "Id": "Microsoft.Azure.Cosmos.Handlers.PartitionKeyRangeGoneRetryHandler",
            "ElapsedTime": "00:00:00.0061567"
        },
        {
            "Id": "Microsoft.Azure.Cosmos.Handlers.PartitionKeyRangeHandler",
            "ElapsedTime": "00:00:00.0058375"
        },
        {
            "Id": "Microsoft.Azure.Cosmos.Handlers.TransportHandler",
            "ElapsedTime": "00:00:00.0044057"
        },
        {
            "Id": "TransportHandler",
            "ElapsedTime": "00:00:00.0043484"
        },
        {
            "Id": "StoreResponseStatistics",
            "ResponseTimeUtc": "2020-02-21T16:15:22.8032320Z",
            "ResourceType": "Document",
            "OperationType": "ReadFeed",
            "LocationEndpoint": "https://127.0.0.1:8081/",
            "StoreResult": "StorePhysicalAddress: rntbd://127.0.0.1:10253/apps/DocDbApp/services/DocDbServer18/partitions/a4cb495e-38c8-11e6-8106-8cdcd42c33be/replicas/1p/, LSN: 593, GlobalCommittedLsn: -1, PartitionKeyRangeId: , IsValid: True, StatusCode: 429, SubStatusCode: 3200, RequestCharge: 0.38, ItemLSN: -1, SessionToken: -1#593, UsingLocalLSN: True, TransportException: null"
        },
        {
            "Id": "Microsoft.Azure.Cosmos.Handlers.RouterHandler",
            "ElapsedTime": "00:00:00.0238693"
        },
        {
            "Id": "Microsoft.Azure.Cosmos.Handlers.PartitionKeyRangeGoneRetryHandler",
            "ElapsedTime": "00:00:00.0203965"
        },
        {
            "Id": "Microsoft.Azure.Cosmos.Handlers.PartitionKeyRangeHandler",
            "ElapsedTime": "00:00:00.0179438"
        },
        {
            "Id": "Microsoft.Azure.Cosmos.Handlers.TransportHandler",
            "ElapsedTime": "00:00:00.0166196"
        },
        {
            "Id": "TransportHandler",
            "ElapsedTime": "00:00:00.0166154"
        },
        {
            "Id": "StoreResponseStatistics",
            "ResponseTimeUtc": "2020-02-21T16:15:23.3309716Z",
            "ResourceType": "Document",
            "OperationType": "ReadFeed",
            "LocationEndpoint": "https://127.0.0.1:8081/",
            "StoreResult": "StorePhysicalAddress: rntbd://127.0.0.1:10253/apps/DocDbApp/services/DocDbServer18/partitions/a4cb495e-38c8-11e6-8106-8cdcd42c33be/replicas/1p/, LSN: 593, GlobalCommittedLsn: -1, PartitionKeyRangeId: , IsValid: True, StatusCode: 429, SubStatusCode: 3200, RequestCharge: 0.38, ItemLSN: -1, SessionToken: -1#593, UsingLocalLSN: True, TransportException: null"
        },
        {
            "Id": "Microsoft.Azure.Cosmos.Handlers.RouterHandler",
            "ElapsedTime": "00:00:00.0415970"
        },
        {
            "Id": "Microsoft.Azure.Cosmos.Handlers.PartitionKeyRangeGoneRetryHandler",
            "ElapsedTime": "00:00:00.0415612"
        },
        {
            "Id": "Microsoft.Azure.Cosmos.Handlers.PartitionKeyRangeHandler",
            "ElapsedTime": "00:00:00.0415444"
        },
        {
            "Id": "Microsoft.Azure.Cosmos.Handlers.TransportHandler",
            "ElapsedTime": "00:00:00.0413541"
        },
        {
            "Id": "TransportHandler",
            "ElapsedTime": "00:00:00.0413493"
        },
        {
            "Id": "StoreResponseStatistics",
            "ResponseTimeUtc": "2020-02-21T16:15:23.9024024Z",
            "ResourceType": "Document",
            "OperationType": "ReadFeed",
            "LocationEndpoint": "https://127.0.0.1:8081/",
            "StoreResult": "StorePhysicalAddress: rntbd://127.0.0.1:10253/apps/DocDbApp/services/DocDbServer18/partitions/a4cb495e-38c8-11e6-8106-8cdcd42c33be/replicas/1p/, LSN: 593, GlobalCommittedLsn: -1, PartitionKeyRangeId: , IsValid: True, StatusCode: 429, SubStatusCode: 3200, RequestCharge: 0.38, ItemLSN: -1, SessionToken: -1#593, UsingLocalLSN: True, TransportException: null"
        },
        {
            "Id": "Microsoft.Azure.Cosmos.Handlers.RouterHandler",
            "ElapsedTime": "00:00:00.0562729"
        },
        {
            "Id": "Microsoft.Azure.Cosmos.Handlers.PartitionKeyRangeGoneRetryHandler",
            "ElapsedTime": "00:00:00.0562533"
        },
        {
            "Id": "Microsoft.Azure.Cosmos.Handlers.PartitionKeyRangeHandler",
            "ElapsedTime": "00:00:00.0562374"
        },
        {
            "Id": "Microsoft.Azure.Cosmos.Handlers.TransportHandler",
            "ElapsedTime": "00:00:00.0559870"
        },
        {
            "Id": "TransportHandler",
            "ElapsedTime": "00:00:00.0559813"
        },
        {
            "Id": "StoreResponseStatistics",
            "ResponseTimeUtc": "2020-02-21T16:15:24.4634983Z",
            "ResourceType": "Document",
            "OperationType": "ReadFeed",
            "LocationEndpoint": "https://127.0.0.1:8081/",
            "StoreResult": "StorePhysicalAddress: rntbd://127.0.0.1:10253/apps/DocDbApp/services/DocDbServer18/partitions/a4cb495e-38c8-11e6-8106-8cdcd42c33be/replicas/1p/, LSN: 593, GlobalCommittedLsn: -1, PartitionKeyRangeId: , IsValid: True, StatusCode: 429, SubStatusCode: 3200, RequestCharge: 0.38, ItemLSN: -1, SessionToken: -1#593, UsingLocalLSN: True, TransportException: null"
        },
        {
            "Id": "Microsoft.Azure.Cosmos.Handlers.RouterHandler",
            "ElapsedTime": "00:00:00.0929813"
        },
        {
            "Id": "Microsoft.Azure.Cosmos.Handlers.PartitionKeyRangeGoneRetryHandler",
            "ElapsedTime": "00:00:00.0929240"
        },
        {
            "Id": "Microsoft.Azure.Cosmos.Handlers.PartitionKeyRangeHandler",
            "ElapsedTime": "00:00:00.0929059"
        },
        {
            "Id": "Microsoft.Azure.Cosmos.Handlers.TransportHandler",
            "ElapsedTime": "00:00:00.0926857"
        },
        {
            "Id": "TransportHandler",
            "ElapsedTime": "00:00:00.0923922"
        },
        {
            "Id": "StoreResponseStatistics",
            "ResponseTimeUtc": "2020-02-21T16:15:25.1784405Z",
            "ResourceType": "Document",
            "OperationType": "ReadFeed",
            "LocationEndpoint": "https://127.0.0.1:8081/",
            "StoreResult": "StorePhysicalAddress: rntbd://127.0.0.1:10253/apps/DocDbApp/services/DocDbServer18/partitions/a4cb495e-38c8-11e6-8106-8cdcd42c33be/replicas/1p/, LSN: 593, GlobalCommittedLsn: -1, PartitionKeyRangeId: , IsValid: True, StatusCode: 429, SubStatusCode: 3200, RequestCharge: 0.38, ItemLSN: -1, SessionToken: -1#593, UsingLocalLSN: True, TransportException: null"
        },
        {
            "Id": "Microsoft.Azure.Cosmos.Handlers.RouterHandler",
            "ElapsedTime": "00:00:00.0899527"
        },
        {
            "Id": "Microsoft.Azure.Cosmos.Handlers.PartitionKeyRangeGoneRetryHandler",
            "ElapsedTime": "00:00:00.0898841"
        },
        {
            "Id": "Microsoft.Azure.Cosmos.Handlers.PartitionKeyRangeHandler",
            "ElapsedTime": "00:00:00.0898696"
        },
        {
            "Id": "Microsoft.Azure.Cosmos.Handlers.TransportHandler",
            "ElapsedTime": "00:00:00.0893097"
        },
        {
            "Id": "TransportHandler",
            "ElapsedTime": "00:00:00.0893053"
        },
        {
            "Id": "StoreResponseStatistics",
            "ResponseTimeUtc": "2020-02-21T16:15:25.8928412Z",
            "ResourceType": "Document",
            "OperationType": "ReadFeed",
            "LocationEndpoint": "https://127.0.0.1:8081/",
            "StoreResult": "StorePhysicalAddress: rntbd://127.0.0.1:10253/apps/DocDbApp/services/DocDbServer18/partitions/a4cb495e-38c8-11e6-8106-8cdcd42c33be/replicas/1p/, LSN: 593, GlobalCommittedLsn: -1, PartitionKeyRangeId: , IsValid: True, StatusCode: 429, SubStatusCode: 3200, RequestCharge: 0.38, ItemLSN: -1, SessionToken: -1#593, UsingLocalLSN: True, TransportException: null"
        },
        {
            "Id": "Microsoft.Azure.Cosmos.Handlers.RouterHandler",
            "ElapsedTime": "00:00:00.2555311"
        },
        {
            "Id": "Microsoft.Azure.Cosmos.Handlers.PartitionKeyRangeGoneRetryHandler",
            "ElapsedTime": "00:00:00.2554676"
        },
        {
            "Id": "Microsoft.Azure.Cosmos.Handlers.PartitionKeyRangeHandler",
            "ElapsedTime": "00:00:00.2554134"
        },
        {
            "Id": "Microsoft.Azure.Cosmos.Handlers.TransportHandler",
            "ElapsedTime": "00:00:00.2553524"
        },
        {
            "Id": "TransportHandler",
            "ElapsedTime": "00:00:00.2553460"
        },
        {
            "Id": "StoreResponseStatistics",
            "ResponseTimeUtc": "2020-02-21T16:15:26.3125424Z",
            "ResourceType": "Document",
            "OperationType": "ReadFeed",
            "LocationEndpoint": "https://127.0.0.1:8081/",
            "StoreResult": "StorePhysicalAddress: rntbd://127.0.0.1:10253/apps/DocDbApp/services/DocDbServer18/partitions/a4cb495e-38c8-11e6-8106-8cdcd42c33be/replicas/1p/, LSN: 593, GlobalCommittedLsn: -1, PartitionKeyRangeId: , IsValid: True, StatusCode: 429, SubStatusCode: 3200, RequestCharge: 0.38, ItemLSN: -1, SessionToken: -1#593, UsingLocalLSN: True, TransportException: null"
        },
        {
            "Id": "Microsoft.Azure.Cosmos.Handlers.RouterHandler",
            "ElapsedTime": "00:00:00.1624049"
        },
        {
            "Id": "Microsoft.Azure.Cosmos.Handlers.PartitionKeyRangeGoneRetryHandler",
            "ElapsedTime": "00:00:00.1622933"
        },
        {
            "Id": "Microsoft.Azure.Cosmos.Handlers.PartitionKeyRangeHandler",
            "ElapsedTime": "00:00:00.1620922"
        },
        {
            "Id": "Microsoft.Azure.Cosmos.Handlers.TransportHandler",
            "ElapsedTime": "00:00:00.1619038"
        },
        {
            "Id": "TransportHandler",
            "ElapsedTime": "00:00:00.1613700"
        },
        {
            "Id": "StoreResponseStatistics",
            "ResponseTimeUtc": "2020-02-21T16:15:27.1158560Z",
            "ResourceType": "Document",
            "OperationType": "ReadFeed",
            "LocationEndpoint": "https://127.0.0.1:8081/",
            "StoreResult": "StorePhysicalAddress: rntbd://127.0.0.1:10253/apps/DocDbApp/services/DocDbServer18/partitions/a4cb495e-38c8-11e6-8106-8cdcd42c33be/replicas/1p/, LSN: 593, GlobalCommittedLsn: -1, PartitionKeyRangeId: , IsValid: True, StatusCode: 429, SubStatusCode: 3200, RequestCharge: 0.38, ItemLSN: -1, SessionToken: -1#593, UsingLocalLSN: True, TransportException: null"
        },
        {
            "Id": "Microsoft.Azure.Cosmos.Handlers.RouterHandler",
            "ElapsedTime": "00:00:00.0984888"
        },
        {
            "Id": "Microsoft.Azure.Cosmos.Handlers.PartitionKeyRangeGoneRetryHandler",
            "ElapsedTime": "00:00:00.0984235"
        },
        {
            "Id": "Microsoft.Azure.Cosmos.Handlers.PartitionKeyRangeHandler",
            "ElapsedTime": "00:00:00.0251216"
        },
        {
            "Id": "Microsoft.Azure.Cosmos.Handlers.TransportHandler",
            "ElapsedTime": "00:00:00.0248447"
        },
        {
            "Id": "TransportHandler",
            "ElapsedTime": "00:00:00.0248356"
        },
        {
            "Id": "StoreResponseStatistics",
            "ResponseTimeUtc": "2020-02-21T16:15:27.8642904Z",
            "ResourceType": "Document",
            "OperationType": "ReadFeed",
            "LocationEndpoint": "https://127.0.0.1:8081/",
            "StoreResult": "StorePhysicalAddress: rntbd://127.0.0.1:10253/apps/DocDbApp/services/DocDbServer18/partitions/a4cb495e-38c8-11e6-8106-8cdcd42c33be/replicas/1p/, LSN: 593, GlobalCommittedLsn: -1, PartitionKeyRangeId: , IsValid: True, StatusCode: 429, SubStatusCode: 3200, RequestCharge: 0.38, ItemLSN: -1, SessionToken: -1#593, UsingLocalLSN: True, TransportException: null"
        }
    ]
}

Microsoft.Azure.Cosmos/src/Diagnostics/AddressResolutionStatistics.cs

Microsoft.Azure.Cosmos/src/Diagnostics/CosmosClientSideRequestStatistics.cs

bchong95 · 2020-02-01T01:27:02Z

Microsoft.Azure.Cosmos/src/Diagnostics/CosmosDiagnosticsContextCore.cs

@@ -93,6 +93,21 @@ internal override void AddDiagnosticsInternal(PointOperationStatistics pointOper
            this.ContextList.Add(pointOperationStatistics);
        }

+        internal override void AddDiagnosticsInternal(StoreResponseStatistics storeResponseStatistics)


You could probably write a visitor for this, so you will know to update this when a new type gets added.

The problem is abstract classes. It can't be both a CosmosDiagnosticsInternal and a CosmosDiagnosticsInternalVisitor. Also it does not need to support all vistors.

Microsoft.Azure.Cosmos/src/Diagnostics/StoreResponseStatistics.cs

…f the last call.

…c context on tostring to avoid missing information.

…void breaking changes.

kirankumarkolli · 2020-02-20T20:30:03Z

    private IClientSideRequestStatistics sharedStatistics;

What's the value of this now?

Refers to: Microsoft.Azure.Cosmos/src/ClientRetryPolicy.cs:36 in 4c694dc. [](commit_id = 4c694dc, deletion_comment = False)

kirankumarkolli

… requests better.

…diagnostic context.

Microsoft.Azure.Cosmos/src/Diagnostics/CosmosClientSideRequestStatistics.cs

…iagnosticContext to get the full information.

…nostics/fix_client_stats

Jake Willey added 8 commits January 28, 2020 10:07

Add ability to disable diagnostic on a request level.

86075a3

Updated unit test

b240f37

Exposed API in request options

d848d11

Updated naming

c9389ac

Renamed to Empty as prefix

4f9bcf9

Moving CosmosClientSideRequestStatistics to diagnostics

b17a88b

CosmosClientSideRequestStatistics is integrated into DiagnosticContext.

02c8ba3

Merged with master

f1d261a

j82w requested review from bchong95, khdang, kirankumarkolli and kirillg as code owners January 31, 2020 21:24

j82w self-assigned this Jan 31, 2020

j82w added the Diagnostics Issues around diagnostics and troubleshooting label Jan 31, 2020

bchong95 reviewed Jan 31, 2020

View reviewed changes

Microsoft.Azure.Cosmos/src/Diagnostics/AddressResolutionStatistics.cs Outdated Show resolved Hide resolved

bchong95 reviewed Jan 31, 2020

View reviewed changes

Microsoft.Azure.Cosmos/src/Diagnostics/CosmosClientSideRequestStatistics.cs Show resolved Hide resolved

bchong95 reviewed Feb 1, 2020

View reviewed changes

Microsoft.Azure.Cosmos/src/Diagnostics/StoreResponseStatistics.cs Outdated Show resolved Hide resolved

bchong95 reviewed Feb 1, 2020

View reviewed changes

Microsoft.Azure.Cosmos/src/Diagnostics/StoreResponseStatistics.cs Show resolved Hide resolved

bchong95 previously approved these changes Feb 1, 2020

View reviewed changes

Jake Willey added 2 commits February 3, 2020 06:57

Fixing comments

5759c30

Updated baseline test

d456c50

j82w dismissed bchong95’s stale review via d456c50 February 3, 2020 15:24

Jake Willey added 6 commits February 3, 2020 12:03

Create if not exist API now contain all context information instead o…

f93f7a9

…f the last call.

Updated CosmosClientSideRequestStatistics to include entire diagnosti…

66b7021

…c context on tostring to avoid missing information.

IClientSideRequestStatistics now returns the v2 ToString version to a…

fdf7272

…void breaking changes.

Switched client side request stats to print the entire diagnostics.

5ed2d4d

Handle null store result

cc582b2

Fixed unit test

4c694dc

Fixed tests, added response time to PointOperationStats

823abda

kirankumarkolli previously approved these changes Feb 25, 2020

View reviewed changes

FabianMeiswinkel previously approved these changes Feb 25, 2020

View reviewed changes

Jake Willey added 2 commits March 3, 2020 06:42

Merge to latest

676d14f

Merged to latest

892d0bc

j82w dismissed stale reviews from FabianMeiswinkel and kirankumarkolli via 892d0bc March 3, 2020 14:53

Jake Willey added 8 commits March 3, 2020 13:34

Removed unused using statements

1571fe8

Removed using statement

cc52693

merge to latest

78857c1

Removed using statement to trigger new build

9c673ce

Trigger new build

ee00f16

Fix not found exception

92d36b7

Refactored to use CTOR when possible. Updated logic to handle gateway…

dfb448b

… requests better.

Add v2 compatibility to avoid issues from the additional size of the …

70afa4d

…diagnostic context.

kirankumarkolli previously approved these changes Mar 5, 2020

View reviewed changes

Added Utc to end of time properties.

f19e095

j82w dismissed kirankumarkolli’s stale review via f19e095 March 5, 2020 15:12

Jake Willey added 4 commits March 5, 2020 13:28

Fixed null ref exception

b654f15

Fixed error message

cbe8cc9

Merge to latest

f50b4fc

Updated test

ea7a9e9

ealsur previously approved these changes Mar 9, 2020

View reviewed changes

IClientSideRequestStatistics ToString methods now just call the new D…

bdf4e4f

…iagnosticContext to get the full information.

j82w dismissed ealsur’s stale review via bdf4e4f March 9, 2020 18:56

Jake Willey added 2 commits March 9, 2020 12:35

Fixed unit test

5773d1c

Merge remote-tracking branch 'origin/master' into users/jawilley/diag…

70451e4

…nostics/fix_client_stats

ealsur approved these changes Mar 10, 2020

View reviewed changes

j82w merged commit 16f054a into master Mar 10, 2020

j82w deleted the users/jawilley/diagnostics/fix_client_stats branch March 10, 2020 18:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CosmosClientSideRequestStatistics merged into DiagnosticContext #1189

CosmosClientSideRequestStatistics merged into DiagnosticContext #1189

j82w commented Jan 31, 2020 •

edited

Loading

bchong95 Feb 1, 2020

j82w Feb 3, 2020 •

edited

Loading

kirankumarkolli commented Feb 20, 2020

kirankumarkolli left a comment

CosmosClientSideRequestStatistics merged into DiagnosticContext #1189

CosmosClientSideRequestStatistics merged into DiagnosticContext #1189

Conversation

j82w commented Jan 31, 2020 • edited Loading

Pull Request Template

Description

Type of change

bchong95 Feb 1, 2020

Choose a reason for hiding this comment

j82w Feb 3, 2020 • edited Loading

Choose a reason for hiding this comment

kirankumarkolli commented Feb 20, 2020

kirankumarkolli left a comment

Choose a reason for hiding this comment

j82w commented Jan 31, 2020 •

edited

Loading

j82w Feb 3, 2020 •

edited

Loading