Fixed missing retry after for stream queries. #1263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ously the header would not get set in the query stream APIs.
ealsur
previously approved these changes
Mar 9, 2020
| @@ -192,10 +192,10 @@ private static string MergeErrorMessages(string message, Error error) | |||
|
|
|||
| if (string.IsNullOrEmpty(message)) | |||
| { | |||
| return error.Message; | |||
| return error.ToString(); | |||
There was a problem hiding this comment.
I didn't realize that Error is a JSON bag and some error objects don't put it in the message so only ToString() shows it.
kirankumarkolli
previously approved these changes
Mar 12, 2020
added 2 commits
March 16, 2020 06:47
added 4 commits
March 17, 2020 06:01
…g tests in parallel.
ealsur
approved these changes
Mar 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
This fixes a bug where retry after was not getting set on throttle responses for
GetItemQueryStreamIterator. Adds additional test to validate the retry after time is always set.Type of change
Please delete options that are not relevant.