Client Encryption - Decrypt the encrypted properties before returning query result #1296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anujtoshniwal
requested review from
bchong95,
j82w and
kirankumarkolli
as code owners
abhijitpai
reviewed
Mar 23, 2020
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/EncryptionTests.cs
Outdated
Show resolved
Hide resolved
bchong95
reviewed
Mar 23, 2020
Microsoft.Azure.Cosmos/src/Query/v3Query/CosmosQueryClientCore.cs
Outdated
Show resolved
Hide resolved
j82w
reviewed
Mar 23, 2020
Microsoft.Azure.Cosmos/src/Query/v3Query/CosmosQueryClientCore.cs
Outdated
Show resolved
Hide resolved
bchong95
reviewed
Mar 23, 2020
Microsoft.Azure.Cosmos/src/Query/v3Query/CosmosQueryClientCore.cs
Outdated
Show resolved
Hide resolved
j82w
reviewed
Mar 24, 2020
Microsoft.Azure.Cosmos/src/Query/v3Query/CosmosQueryClientCore.cs
Outdated
Show resolved
Hide resolved
abhijitpai
reviewed
Mar 25, 2020
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/EncryptionTests.cs
Show resolved
Hide resolved
abhijitpai
reviewed
Mar 25, 2020
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/EncryptionTests.cs
Outdated
Show resolved
Hide resolved
abhijitpai
reviewed
Mar 26, 2020
bchong95
reviewed
Mar 26, 2020
bchong95
reviewed
Mar 26, 2020
bchong95
reviewed
Mar 26, 2020
bchong95
reviewed
Mar 26, 2020
bchong95
reviewed
Mar 26, 2020
bchong95
reviewed
Mar 26, 2020
bchong95
reviewed
Mar 26, 2020
bchong95
reviewed
Mar 26, 2020
Microsoft.Azure.Cosmos/src/Query/v3Query/CosmosQueryClientCore.cs
Outdated
Show resolved
Hide resolved
bchong95
reviewed
Mar 26, 2020
Microsoft.Azure.Cosmos/src/Query/v3Query/CosmosQueryClientCore.cs
Outdated
Show resolved
Hide resolved
bchong95
previously approved these changes
Mar 26, 2020
Microsoft.Azure.Cosmos/src/Query/v3Query/CosmosQueryClientCore.cs
Outdated
Show resolved
Hide resolved
kirankumarkolli
previously approved these changes
Mar 27, 2020
kirankumarkolli
approved these changes
Mar 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
While we do not support filtering on encrypted properties etc., for queries where the full item would be returned, we want to decrypt the encrypted properties on the client before returning the query result.
Type of change