CosmosClientOptions: Add ApplicationPreferredRegions #1305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhijitpai
reviewed
Mar 26, 2020
abhijitpai
previously approved these changes
Mar 26, 2020
j82w
reviewed
Mar 27, 2020
|
|
||
| [TestMethod] | ||
| [ExpectedException(typeof(ArgumentException))] | ||
| public void VerifyLimitToEndpointSettingsWithPreferredRegions() |
There was a problem hiding this comment.
This is probably outside the scope of this PR but is there any way to validate the SDK is following the order provided?
There was a problem hiding this comment.
Good question, I believe it depends on the error. I've seen logic in the ClientRetryPolicy which should honor the order but other that are actively not honoring it. I am not familiar with why it works like that.
|
@kirillg FYR we are adding preferred locations as explicit specification. |
bchong95
reviewed
Mar 30, 2020
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/DotNetSDKAPI.json
Outdated
Show resolved
Hide resolved
kirankumarkolli
previously approved these changes
Apr 3, 2020
kirankumarkolli
approved these changes
Apr 3, 2020
j82w
reviewed
Apr 3, 2020
j82w
approved these changes
Apr 3, 2020
ealsur
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ealsur
changed the title
ealsur
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
The most common use case for global availability is for applications to specify
ApplicationRegioninCosmosClientOptions.ApplicationRegiondefines where is the current application running and lets the SDK populate the list of preferred regions based on availability (which regions the account is available on) and distance (closest regions first).There are however, some situations where the application might want to manually specify the order of preference.
This PR adds the
CosmosClientOptions.ApplicationPreferredRegionsto enable these scenarios as an alternative toApplicationRegion. Both cannot be set.Type of change
Closing issues
Closes #1306