Autoscale: Add to official release and do renames #1428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j82w
requested review from
ealsur,
FabianMeiswinkel,
kirankumarkolli and
kirillg
as code owners
ealsur
previously approved these changes
Apr 24, 2020
bchong95
reviewed
Apr 25, 2020
Microsoft.Azure.Cosmos/src/Resource/Settings/ThroughputProperties.cs
Outdated
Show resolved
Hide resolved
bchong95
reviewed
Apr 25, 2020
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/CosmosThroughputTests.cs
Outdated
Show resolved
Hide resolved
kirankumarkolli
previously approved these changes
Apr 29, 2020
|
Looks good to me. |
FabianMeiswinkel
previously approved these changes
Apr 30, 2020
added 3 commits
April 30, 2020 07:19
…/Azure/azure-cosmos-dotnet-v3 into users/jawilley/autoscale/renames
j82w
dismissed stale reviews from FabianMeiswinkel, kirankumarkolli, and ealsur
via
d9e3ea5
j82w
changed the title
kirankumarkolli
approved these changes
May 1, 2020
kirankumarkolli
approved these changes
May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
This changing the property names based on feedback.
Create throughput is the same:
ThroughputProperties throughputProperties = ThroughputProperties.CreateAutoscaleThroughput(6000);New property name:
throughputProperties.AutoscaleMaxThroughputOld property name:
throughputProperties.MaxAutoscaleThroughputType of change
Please delete options that are not relevant.