Diagnostics: Fix ToString() to not grow exponentially with retries #1539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j82w
added
bug
j82w
requested review from
bchong95,
ealsur,
FabianMeiswinkel,
khdang,
kirankumarkolli,
kirillg and
sboshra
as code owners
added 2 commits
May 19, 2020 06:27
FabianMeiswinkel
previously approved these changes
May 19, 2020
ealsur
previously approved these changes
May 19, 2020
...osoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Utils/TransportClientHelper.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/CosmosDiagnosticsTests.cs
Show resolved
Hide resolved
kirankumarkolli
previously approved these changes
May 19, 2020
kirankumarkolli
changed the title
j82w
changed the title
j82w
dismissed stale reviews from kirankumarkolli, ealsur, and FabianMeiswinkel
via
8a15a18
4 tasks
ealsur
approved these changes
May 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
This fixes a bug in the diagnostics where a circle reference was created causing the diagnostics
ToString()to grow exponentially.The
CosmosClientSideRequestStatisticsdirectly adds the content to theCosmosDiagnostics. Some of theDocumentClientExceptionsinclude theIClientSideRequestStatisticsin the message which would then call theCosmosDiagnostic.ToString(). TheCosmosDiagnosticrecords eachDocumentClientExceptionsand adds the message to it's records creating a circle reference.Type of change
Please delete options that are not relevant.