CosmosOperationCanceledException: Add CosmosDiagnostic info #1550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j82w
requested review from
bchong95,
ealsur,
FabianMeiswinkel,
khdang,
kirankumarkolli,
kirillg and
sboshra
as code owners
Microsoft.Azure.Cosmos/src/Resource/CosmosExceptions/CosmosOperationCanceledException.cs
Show resolved
Hide resolved
kirankumarkolli
requested changes
May 21, 2020
Microsoft.Azure.Cosmos/src/Resource/CosmosExceptions/CosmosOperationCanceledException.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Resource/CosmosExceptions/CosmosOperationCanceledException.cs
Outdated
Show resolved
Hide resolved
added 3 commits
May 27, 2020 07:18
…nostics/operationCancelled
Microsoft.Azure.Cosmos/src/Resource/CosmosExceptions/CosmosOperationCanceledException.cs
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Resource/CosmosExceptions/CosmosOperationCanceledException.cs
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Resource/CosmosExceptions/CosmosOperationCanceledException.cs
Outdated
Show resolved
Hide resolved
FabianMeiswinkel
previously approved these changes
May 28, 2020
Microsoft.Azure.Cosmos/src/Query/Core/ExecutionContext/CatchAllCosmosQueryExecutionContext.cs
Outdated
Show resolved
Hide resolved
added 2 commits
May 28, 2020 14:56
…nostics/operationCancelled
j82w
changed the title
kirankumarkolli
approved these changes
May 31, 2020
This was referenced Mar 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
This adds CosmosDiagnostic information to OperationCanceledException and TaskCanceledException . This is necessary to help troubleshoot operations that get cancelled. Currently all the diagnostics get lost and there is no way to access this information. This wraps the system types with a Cosmos type then it overrides the ToString() to add the CosmosDiagnostic information to it.
Type of change
Please delete options that are not relevant.
Closing issues
Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).
Assignee
Please add yourself as the assignee
Projects
Please add relevant projects so this issue can be properly tracked.