Diagnostics: Add synchronization context Part 1 #1587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j82w
requested review from
bchong95,
ealsur,
FabianMeiswinkel,
khdang,
kirankumarkolli,
kirillg and
sboshra
as code owners
Microsoft.Azure.Cosmos/src/Diagnostics/CosmosClientSideRequestStatistics.cs
Show resolved
Hide resolved
Unrelated to this PR: Container has its own implementation for it. Refers to: Microsoft.Azure.Cosmos/src/Resource/ClientContextCore.cs:318 in b8bc976. [](commit_id = b8bc976, deletion_comment = False) |
ealsur
reviewed
Jun 2, 2020
Microsoft.Azure.Cosmos/src/Diagnostics/CosmosDiagnosticsContext.cs
Outdated
Show resolved
Hide resolved
FabianMeiswinkel
previously approved these changes
Jun 10, 2020
| @@ -309,7 +309,7 @@ public virtual Task<AccountProperties> ReadAccountAsync() | |||
| /// <param name="id">The Cosmos database id</param> | |||
| /// <remarks> | |||
| /// <see cref="Database"/> proxy reference doesn't guarantee existence. | |||
| /// Please ensure database exists through <see cref="CosmosClient.CreateDatabaseAsync(DatabaseProperties, int?, RequestOptions, CancellationToken)"/> | |||
| /// Please ensure database exists through <see cref="CosmosClient.CreateDatabaseAsync(string, int?, RequestOptions, CancellationToken)"/> | |||
There was a problem hiding this comment.
Are there any mechanisms which we could use to get consistency?
Like referring real code snippet like in the public docs?
Non blocking but will immensely help forward.
There was a problem hiding this comment.
This was pointing to a real snippet of code, it's just an internal method.
kirankumarkolli
previously approved these changes
Jun 11, 2020
kirankumarkolli
approved these changes
Jun 15, 2020
j82w
deleted the
users/jawilley/diagnostics/includeTaskRunTime_newContracts
branch
This was referenced Jun 18, 2020
kirankumarkolli
pushed a commit
that referenced
this pull request
Jul 11, 2020
* Diagnostic refactor for synchronization context * Added Database changes to give more context on how it will look for inline classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
This is part 1 with mostly just the diagnostic context changes and the CosmosClient updated to use the new interface. Other classes will be done in follow up PRs.
Type of change
Please delete options that are not relevant.
Closing issues
Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).
Assignee
Please add yourself as the assignee
Projects
Please add relevant projects so this issue can be properly tracked.