Query: Fix memory leak by making FeedIterator IDisposable #1613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j82w
requested review from
bchong95,
ealsur,
FabianMeiswinkel,
khdang,
kirankumarkolli,
kirillg and
sboshra
as code owners
bchong95
reviewed
Jun 11, 2020
Microsoft.Azure.Cosmos/src/Resource/FeedIterators/FeedIteratorInlineCore.cs
Outdated
Show resolved
Hide resolved
bchong95
reviewed
Jun 11, 2020
Microsoft.Azure.Cosmos/src/Resource/FeedIterators/FeedIteratorInlineCore.cs
Show resolved
Hide resolved
bchong95
reviewed
Jun 11, 2020
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Query/SanityQueryTests.cs
Outdated
Show resolved
Hide resolved
bchong95
previously approved these changes
Jun 11, 2020
FabianMeiswinkel
previously approved these changes
Jun 11, 2020
kirankumarkolli
previously approved these changes
Jun 11, 2020
j82w
changed the title
j82w
dismissed stale reviews from kirankumarkolli and FabianMeiswinkel
via
d4220e6
j82w
changed the title
kirankumarkolli
approved these changes
Jun 11, 2020
|
Closing due to in-activity, pease feel free to re-open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
This PR adds IDisposable to the FeedIterators to fix a memory leak caused by the query logic buffering pages in the background. The FeedIterators have default implementation to avoid breaking any users that are extending the base abstract class.
NOTE: BREAKING CHANGE
Any users that have a static analysis tool checking for IDisposable will be broken when upgrade to this version.
Type of change
Please delete options that are not relevant.
Closing issues
Put closes #1607
Assignee
Please add yourself as the assignee
Projects
Please add relevant projects so this issue can be properly tracked.