Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog: Fix spelling and update format #1696

Merged
merged 4 commits into from
Jul 14, 2020
Merged

Conversation

SnehaGunda
Copy link
Contributor

@SnehaGunda SnehaGunda commented Jul 10, 2020

Pull Request Template

Description

This fixes spelling and other grammar issues with the changelog.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Closing issues

Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

Assignee

Please add yourself as the assignee

Projects

Please add relevant projects so this issue can be properly tracked.

changelog.md Outdated
- [#1398](https://github.com/Azure/azure-cosmos-dotnet-v3/pull/1398) & [#1516](https://github.com/Azure/azure-cosmos-dotnet-v3/pull/1516) Read feed and change feed: Add serialization optimization to reduce memory and cpu utlization upto 90%. Object are now passed as an array to the serializer.
- [#1516](https://github.com/Azure/azure-cosmos-dotnet-v3/pull/1516) Query: Add serialization optimization to reduce memory upto %50 and cpu utlization upto 25%. Object are now passed as an array to the serializer.
- [#1356](https://github.com/Azure/azure-cosmos-dotnet-v3/pull/1356) & [#1407](https://github.com/Azure/azure-cosmos-dotnet-v3/pull/1407) & [#1428](https://github.com/Azure/azure-cosmos-dotnet-v3/pull/1428) & [#1407](https://github.com/Azure/azure-cosmos-dotnet-v3/pull/1407) Added autoscale support.
- [#1398](https://github.com/Azure/azure-cosmos-dotnet-v3/pull/1398) Diagnostics: Added CPU monitoring for .NET Core.
Copy link
Contributor

@j82w j82w Jul 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We got feedback that this should be present tense rather than past tense which follows the standard commit message etiquette
#1322 (comment)

Copy link
Contributor Author

@SnehaGunda SnehaGunda Jul 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@j82w Can it be adds or fixes? Add/fix doesn't sound right to me, it sounds like a planned work but this work is already done.
Or we can remove the Add/fix in the individual sentence because the headings already cover them.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll get this merged in today. I first need to update the bot we have to require the new wording.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related PR to update the PR lint tool to follow the new suggestion. #1699

@SnehaGunda SnehaGunda closed this Jul 11, 2020
@SnehaGunda SnehaGunda reopened this Jul 11, 2020
@SnehaGunda
Copy link
Contributor Author

@j82w I am not sure why the build never finished on this PR, can you please merge it ?

@j82w j82w changed the title Format updates to the change log doc Changelog: Fix spelling and update format Jul 14, 2020
@j82w j82w merged commit f3bb918 into Azure:master Jul 14, 2020
@ghost
Copy link

ghost commented Dec 15, 2021

Closing due to in-activity, pease feel free to re-open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants