-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changelog: Fix spelling and update format #1696
Conversation
changelog.md
Outdated
- [#1398](https://github.com/Azure/azure-cosmos-dotnet-v3/pull/1398) & [#1516](https://github.com/Azure/azure-cosmos-dotnet-v3/pull/1516) Read feed and change feed: Add serialization optimization to reduce memory and cpu utlization upto 90%. Object are now passed as an array to the serializer. | ||
- [#1516](https://github.com/Azure/azure-cosmos-dotnet-v3/pull/1516) Query: Add serialization optimization to reduce memory upto %50 and cpu utlization upto 25%. Object are now passed as an array to the serializer. | ||
- [#1356](https://github.com/Azure/azure-cosmos-dotnet-v3/pull/1356) & [#1407](https://github.com/Azure/azure-cosmos-dotnet-v3/pull/1407) & [#1428](https://github.com/Azure/azure-cosmos-dotnet-v3/pull/1428) & [#1407](https://github.com/Azure/azure-cosmos-dotnet-v3/pull/1407) Added autoscale support. | ||
- [#1398](https://github.com/Azure/azure-cosmos-dotnet-v3/pull/1398) Diagnostics: Added CPU monitoring for .NET Core. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We got feedback that this should be present tense rather than past tense which follows the standard commit message etiquette
#1322 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@j82w Can it be adds or fixes? Add/fix doesn't sound right to me, it sounds like a planned work but this work is already done.
Or we can remove the Add/fix in the individual sentence because the headings already cover them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll get this merged in today. I first need to update the bot we have to require the new wording.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related PR to update the PR lint tool to follow the new suggestion. #1699
@j82w I am not sure why the build never finished on this PR, can you please merge it ? |
Closing due to in-activity, pease feel free to re-open. |
Pull Request Template
Description
This fixes spelling and other grammar issues with the changelog.
Type of change
Please delete options that are not relevant.
Closing issues
Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).
Assignee
Please add yourself as the assignee
Projects
Please add relevant projects so this issue can be properly tracked.