Internal ChangeFeed : Fixes Build Breaks #1717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/Azure/azure-cosmos-dotnet-v3 into revert-1684-users/jawilley/contract/changefeed_revert
bchong95
requested review from
ealsur,
FabianMeiswinkel,
j82w,
khdang,
kirankumarkolli,
kirillg and
sboshra
as code owners
ealsur
requested changes
Jul 23, 2020
Microsoft.Azure.Cosmos/src/FeedRange/Continuations/FeedRangeCompositeContinuation.cs
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Resource/QueryResponses/ChangeFeedIteratorCore.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Contracts/ContractTests.cs
Show resolved
Hide resolved
ealsur
approved these changes
Jul 23, 2020
ealsur
previously approved these changes
Jul 23, 2020
sboshra
reviewed
Jul 23, 2020
Microsoft.Azure.Cosmos/src/FeedRange/Continuations/FeedRangeCompositeContinuation.cs
Show resolved
Hide resolved
Base automatically changed from
revert-1684-users/jawilley/contract/changefeed_revert
to
master
July 24, 2020 01:03
sboshra
dismissed stale reviews from ealsur and themself
The base branch was changed.
ealsur
approved these changes
Jul 24, 2020
sboshra
approved these changes
Jul 24, 2020
|
Closing due to in-activity, pease feel free to re-open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal ChangeFeed : Fixes Build Breaks
Description
Fixes the breaks caused by this PR:
#1332
Namely:
API Changes as discussed in #1686 will be made in a follow up PR.