[Internal] Tests: Fixes bad debug assert causing test failures. #1766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j82w
requested review from
ealsur,
FabianMeiswinkel,
kirankumarkolli,
kirillg and
sboshra
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors) Description"
Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.
j82w
changed the title
ealsur
approved these changes
Aug 10, 2020
bchong95
reviewed
Aug 10, 2020
kirankumarkolli
added a commit
that referenced
this pull request
Aug 11, 2020
* Performance: Adds includes compiler optimize option * Update Microsoft.Azure.Cosmos/src/Microsoft.Azure.Cosmos.csproj Co-authored-by: Matias Quaranta <ealsur@users.noreply.github.com> * Update Microsoft.Azure.Cosmos.Samples/Tools/Benchmark/CosmosBenchmark.csproj Co-authored-by: Matias Quaranta <ealsur@users.noreply.github.com> * [Internal] Tests: Fixes bad debug assert causing test failures (#1766) * [Internal] Tests: Fixes tests configuration (#1767) Co-authored-by: j82w <j82w@users.noreply.github.com> * Performance: Adds includes compiler optimize option * Update Microsoft.Azure.Cosmos/src/Microsoft.Azure.Cosmos.csproj Co-authored-by: Matias Quaranta <ealsur@users.noreply.github.com> * Update Microsoft.Azure.Cosmos.Samples/Tools/Benchmark/CosmosBenchmark.csproj Co-authored-by: Matias Quaranta <ealsur@users.noreply.github.com> Co-authored-by: Matias Quaranta <ealsur@users.noreply.github.com> Co-authored-by: j82w <j82w@users.noreply.github.com>
|
Closing due to in-activity, pease feel free to re-open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Fixing a bad debug check that causes tests to fail when in debug mode.
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #IssueNumber