Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SessionToken: Adds optimization to remove session token for stored procedure, triggers, and UDFs #1768

Merged
merged 10 commits into from
Aug 11, 2020

Conversation

j82w
Copy link
Contributor

@j82w j82w commented Aug 10, 2020

Pull Request Template

Description

This fixes a bug where the session token was getting passed for stored procedures, triggers and user defined functions which caused 400 header to large exception. These types are not considered master resources because they execute on the data plane, but all the CRUD operations happen on master which does not require the session token.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] This change requires a documentation update

Closing issues

To automatically close an issue: closes #IssueNumber

@j82w j82w added the bug Something isn't working label Aug 10, 2020
@j82w j82w self-assigned this Aug 10, 2020
ealsur
ealsur previously approved these changes Aug 10, 2020
Copy link
Member

@ealsur ealsur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the tests

Microsoft.Azure.Cosmos/src/GatewayStoreModel.cs Outdated Show resolved Hide resolved
ealsur
ealsur previously approved these changes Aug 11, 2020
@j82w j82w changed the title SessionToken: Fixes a bug where session token was passed for master resources SessionToken: Adds optimization to remove session token for stored procedure, triggers, and UDFs Aug 11, 2020
@j82w j82w merged commit 023ee50 into master Aug 11, 2020
@j82w j82w deleted the users/jawilley/bug/session_token_scripts branch August 11, 2020 20:17
@ghost
Copy link

ghost commented Dec 15, 2021

Closing due to in-activity, pease feel free to re-open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants