-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SessionToken: Adds optimization to remove session token for stored procedure, triggers, and UDFs #1768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j82w
requested review from
bchong95,
ealsur,
FabianMeiswinkel,
khdang,
kirankumarkolli,
kirillg and
sboshra
as code owners
August 10, 2020 20:36
ealsur
previously approved these changes
Aug 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the tests
…thub.com/Azure/azure-cosmos-dotnet-v3 into users/jawilley/bug/session_token_scripts
ealsur
previously approved these changes
Aug 11, 2020
kirankumarkolli
approved these changes
Aug 11, 2020
j82w
changed the title
SessionToken: Fixes a bug where session token was passed for master resources
SessionToken: Adds optimization to remove session token for stored procedure, triggers, and UDFs
Aug 11, 2020
Closing due to in-activity, pease feel free to re-open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
This fixes a bug where the session token was getting passed for stored procedures, triggers and user defined functions which caused 400 header to large exception. These types are not considered master resources because they execute on the data plane, but all the CRUD operations happen on master which does not require the session token.
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #IssueNumber