Performance: Adds headers optimization #1781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Microsoft.Azure.Cosmos/src/Headers/CosmosMessageHeadersInternal.cs # Microsoft.Azure.Cosmos/src/Headers/Headers.cs
# Conflicts: # Microsoft.Azure.Cosmos/src/Headers/Headers.cs
# Conflicts: # Microsoft.Azure.Cosmos/src/Headers/CosmosMessageHeadersInternal.cs # Microsoft.Azure.Cosmos/src/Headers/Headers.cs
# Conflicts: # Microsoft.Azure.Cosmos/src/Headers/Headers.cs
…ception from unnecessary ToString()
j82w
requested review from
bchong95,
ealsur,
FabianMeiswinkel,
khdang,
kirankumarkolli,
kirillg and
sboshra
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors) Description"
Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.
j82w
changed the title
j82w
changed the title
FabianMeiswinkel
previously approved these changes
Aug 18, 2020
kirankumarkolli
requested changes
Aug 18, 2020
|
LockContention highly variable (varies across stream, etc.. it-self), any idea where is it coming from? |
Microsoft.Azure.Cosmos/src/Headers/CosmosMessageHeadersInternal.cs
Outdated
Show resolved
Hide resolved
added 3 commits
August 26, 2020 10:01
kirankumarkolli
approved these changes
Aug 26, 2020
|
Closing due to in-activity, pease feel free to re-open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
This changes the headers to base-line to simple implementation. Benchmarks will be added soon. This continues the current PR: #1619.
Blue is the current PR, Orange is master. Roughly 20% improvement in Rps.
BenchmarkDotNet=v0.12.0, OS=Windows 10.0.17763.1397 (1809/October2018Update/Redstone5)
Intel Xeon Platinum 8272CL CPU 2.60GHz, 1 CPU, 4 logical and 2 physical cores
.NET Core SDK=3.1.401
[Host] : .NET Core 3.1.7 (CoreCLR 4.700.20.36602, CoreFX 4.700.20.37001), X64 RyuJIT
Job-UEAUJY : .NET Core 3.1.7 (CoreCLR 4.700.20.36602, CoreFX 4.700.20.37001), X64 RyuJIT
Improvements on average:
10KB or 28% drop in allocation
40 us or 10% drop in mean latency
Master branch:
Current PR:
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #IssueNumber