Private Preview AAD: Adds AAD support to the SDK #1798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Send AAD token in authorization header. Add a constructor of CosmosClient that takes TokenCredential as an input. Token will be obtained from TokenCredential, cached, and efficiently refreshed in CosmosClient. Update versions of some DLLs (e.g. System.Threading.Tasks.Extensions) as required by [Azure.Core](https://www.nuget.org/packages/Azure.Core/) dependencies. Tests of this change are in !337606 (See /Product/SDK/.net/Microsoft.Azure.Cosmos.Friends/tests/TokenCredentialCacheTests.cs and /Product/Tests/CosmosFabricTest/TestClass/AzureActiveDirectoryTests/AadLegacyGatewayTests.cs) ## Type of change - [ ] New feature (non-breaking change which adds functionality) ## Assignee junyguo
2. Switched from a token refresh that only occurred when it was expiring to a background task that continuously updates the token. This increases availability because the last 5 minutes there might a service outage and the token won't get refreshed in time.
j82w
requested review from
bchong95,
ealsur,
FabianMeiswinkel,
khdang,
kirankumarkolli,
kirillg and
sboshra
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors) Description"
Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.
bchong95
reviewed
Aug 22, 2020
bchong95
reviewed
Aug 22, 2020
bchong95
reviewed
Aug 22, 2020
abhijitpai
reviewed
Aug 24, 2020
abhijitpai
reviewed
Aug 24, 2020
...zure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Utils/LocalEmulatorTokenCredential.cs
Show resolved
Hide resolved
added 6 commits
September 11, 2020 13:53
j82w
changed the title
j82w
changed the title
…azure-cosmos-dotnet-v3 into users/jawilley/aad/AddAAD
ealsur
previously approved these changes
Sep 23, 2020
Microsoft.Azure.Cosmos/src/Authorization/TokenCredentialCache.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Authorization/AuthorizationTokenProviderTokenCredential.cs
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Authorization/TokenCredentialCache.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Authorization/TokenCredentialCache.cs
Outdated
Show resolved
Hide resolved
kirankumarkolli
approved these changes
Sep 24, 2020
|
Closing due to in-activity, pease feel free to re-open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Adds a constructor to take a TokenCredential
Adds a new TokenCredentialCache which store the AAD token while it is valid, and has a background task to refresh the token roughly 25% of the token lifespan.
AuthorizationTokenProvider is created as a base contract for all the authorization interfaces. Each authorization type now has it's own implementation. This avoids runtime exceptions and all the if else logic that is copy pasted everywhere.
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #IssueNumber