Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RequestOptions.Properties: Adds new feature to public SDK #1825

Merged
merged 2 commits into from
Sep 2, 2020
Merged

RequestOptions.Properties: Adds new feature to public SDK #1825

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3207ab5
Make request options properties public
Sep 2, 2020
eded15a
Merge branch 'master' into users/jawilley/feature/properties
j82w Sep 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions Microsoft.Azure.Cosmos/src/RequestOptions/RequestOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,15 +31,10 @@ public class RequestOptions
public string IfNoneMatchEtag { get; set; }

/// <summary>
/// Application opted Cosmos request conext that flow through with the <see cref="RequestMessage" />.
/// Application opted Cosmos request context that flow through with the <see cref="RequestMessage" />.
/// Context will be available through handlers.
/// </summary>
#if PREVIEW
public
#else
internal
#endif
IReadOnlyDictionary<string, object> Properties { get; set; }
public IReadOnlyDictionary<string, object> Properties { get; set; }

/// <summary>
/// Gets or sets the boolean to use effective partition key routing in the cosmos db request.
Expand Down
22 changes: 1 addition & 21 deletions Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/Contracts/DotNetPreviewSDKAPI.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,27 +275,7 @@
"NestedTypes": {}
}
},
"Members": {
"System.Collections.Generic.IReadOnlyDictionary`2[System.String,System.Object] get_Properties()[System.Runtime.CompilerServices.CompilerGeneratedAttribute()]": {
"Type": "Method",
"Attributes": [
"CompilerGeneratedAttribute"
],
"MethodInfo": "System.Collections.Generic.IReadOnlyDictionary`2[System.String,System.Object] get_Properties()"
},
"System.Collections.Generic.IReadOnlyDictionary`2[System.String,System.Object] Properties": {
"Type": "Property",
"Attributes": [],
"MethodInfo": null
},
"Void set_Properties(System.Collections.Generic.IReadOnlyDictionary`2[System.String,System.Object])[System.Runtime.CompilerServices.CompilerGeneratedAttribute()]": {
"Type": "Method",
"Attributes": [
"CompilerGeneratedAttribute"
],
"MethodInfo": "Void set_Properties(System.Collections.Generic.IReadOnlyDictionary`2[System.String,System.Object])"
}
},
"Members": {},
"NestedTypes": {}
}
},
Expand Down
19 changes: 19 additions & 0 deletions Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/Contracts/DotNetSDKAPI.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5362,6 +5362,18 @@
}
},
"Members": {
"System.Collections.Generic.IReadOnlyDictionary`2[System.String,System.Object] get_Properties()[System.Runtime.CompilerServices.CompilerGeneratedAttribute()]": {
"Type": "Method",
"Attributes": [
"CompilerGeneratedAttribute"
],
"MethodInfo": "System.Collections.Generic.IReadOnlyDictionary`2[System.String,System.Object] get_Properties()"
},
"System.Collections.Generic.IReadOnlyDictionary`2[System.String,System.Object] Properties": {
"Type": "Property",
"Attributes": [],
"MethodInfo": null
},
"System.String get_IfMatchEtag()[System.Runtime.CompilerServices.CompilerGeneratedAttribute()]": {
"Type": "Method",
"Attributes": [
Expand Down Expand Up @@ -5404,6 +5416,13 @@
"CompilerGeneratedAttribute"
],
"MethodInfo": "Void set_IfNoneMatchEtag(System.String)"
},
"Void set_Properties(System.Collections.Generic.IReadOnlyDictionary`2[System.String,System.Object])[System.Runtime.CompilerServices.CompilerGeneratedAttribute()]": {
"Type": "Method",
"Attributes": [
"CompilerGeneratedAttribute"
],
"MethodInfo": "Void set_Properties(System.Collections.Generic.IReadOnlyDictionary`2[System.String,System.Object])"
}
},
"NestedTypes": {}
Expand Down